Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E1839. Review requirements and thresholds #1263

Merged
merged 5 commits into from Jan 24, 2019
Merged

Conversation

rayandasoriya
Copy link
Contributor

@rayandasoriya rayandasoriya commented Oct 29, 2018

  • A description of the changes proposed in the pull request.
    -- Added the reviews and meta-reviews left for the students
    -- Improved the UI of the review strategy tab and also improved the grammatical errors existing in the system
    -- Removed unnecessary formatting tags to write clean code following the best Ruby practices.
  • @mentions of the person or team responsible for reviewing proposed changes.
    -- @efg
    Wiki link for the project is available here.

@expertiza-bot
Copy link
Contributor

expertiza-bot commented Oct 29, 2018

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

1 Warning
⚠️ There are code changes, but no corresponding tests.
Please include tests if this PR introduces any modifications in behavior.
You are modifying Gemfile or Gemfile.lock, please double check whether it is necessary.
You are suppose to add a new gem only if you have a very good reason. Try to use existing gems instead.
Please revert changes to Gemfile.lock made by the IDE.

Generated by expertiza-bot

@codeclimate
Copy link

codeclimate bot commented Oct 29, 2018

Code Climate has analyzed commit 7ec00ec and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 47.6% (0.0% change).

View more on Code Climate.

@coveralls
Copy link

coveralls commented Oct 30, 2018

Pull Request Test Coverage Report for Build 5963

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 47.663%

Totals Coverage Status
Change from base Build 5864: 0.02%
Covered Lines: 6353
Relevant Lines: 13329

💛 - Coveralls

@Winbobob Winbobob added the Merge label Dec 13, 2018
@efg efg merged commit 7ec00ec into expertiza:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants