Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E1863-Issue#1017: Issue related to deleting assignment #1324

Merged
merged 2 commits into from Feb 24, 2019

Conversation

tejasgpt
Copy link
Contributor

@tejasgpt tejasgpt commented Dec 7, 2018

Please put the title of your pull request in the following format: Project ID. Name
for example, [Project id/Independent study/Issue fix/...]. project name, eg., E904. Integrating courses and assignments on Expertiza with Moodle

We suggest you include below information in your pull request:

  • A description of the changes proposed in the pull request.
  • @mentions of the person or team responsible for reviewing proposed changes.

@expertiza-bot
Copy link
Contributor

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

1 Warning
⚠️ There are code changes, but no corresponding tests.
Please include tests if this PR introduces any modifications in behavior.

Generated by expertiza-bot

# Issue 101 - allow instructor to delete assignment created by TA.
# FixA : TA can only assignment created by itself.
# FixB : Instrucor will be able to delete any assignment from the list of assignments in the courses.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

@codeclimate
Copy link

codeclimate bot commented Dec 7, 2018

Code Climate has analyzed commit eb0b9af and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 28.8% (-19.5% change).

View more on Code Climate.

@expertiza-travisci-bot
Copy link

Hey @TAG1214,
Your changes look good to me! 🎉

@tejasgpt tejasgpt changed the title Fix for Issue 1017 E1863-Issue#1017: Issue related to deleting assignment Dec 7, 2018
@Winbobob Winbobob merged commit eb0b9af into expertiza:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants