E1854. Improve self-review Link peer review & self-review to derive grades #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by expertiza-bot |
|
Hey @ojasbumblebee, |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/models/response_map.rb
Outdated
| @@ -17,7 +17,8 @@ def self.get_assessments_for(team) | |||
| maps.each do |map| | |||
| next if map.response.empty? | |||
| @all_resp = Response.where(map_id: map.map_id).last | |||
| if map.type.eql?('ReviewResponseMap') | |||
| #if map.type.eql?('ReviewResponseMap') | |||
app/models/response_map.rb
Outdated
| @@ -17,7 +17,8 @@ def self.get_assessments_for(team) | |||
| maps.each do |map| | |||
| next if map.response.empty? | |||
| @all_resp = Response.where(map_id: map.map_id).last | |||
| if map.type.eql?('ReviewResponseMap') | |||
| #if map.type.eql?('ReviewResponseMap') | |||
| if map.type.eql?('ReviewResponseMap') || map.type.eql?('SelfReviewResponseMap') #New Addition | |||
| @peer_avg = @peer_total / (@no_of_columns - 1) | ||
|
|
||
| unless @peer_avg.nan? | ||
| #apply your formula here |
|
|
||
| unless @peer_avg.nan? | ||
| #apply your formula here | ||
| #composite_score = (@self_review_score_of_row + @peer_avg)/ 100 |
| unless @peer_avg.nan? | ||
| #apply your formula here | ||
| #composite_score = (@self_review_score_of_row + @peer_avg)/ 100 | ||
| composite_score = (100 - (@self_review_score_of_row - @peer_avg).abs) * (@peer_avg/100) |
There was a problem hiding this comment.
Surrounding space missing for operator /.
app/models/vm_question_response.rb
Outdated
| @list_of_reviewers << participant | ||
| end | ||
| if participant.id == self_review_mapping.reviewer_id#New addition | ||
| participant = Participant.find(self_review_mapping.reviewer_id) #New addition |
app/models/vm_question_response.rb
Outdated
| end | ||
| if participant.id == self_review_mapping.reviewer_id#New addition | ||
| participant = Participant.find(self_review_mapping.reviewer_id) #New addition | ||
| @list_of_reviewers << participant #New addition |
app/models/vm_question_response.rb
Outdated
| if participant.id == self_review_mapping.reviewer_id#New addition | ||
| participant = Participant.find(self_review_mapping.reviewer_id) #New addition | ||
| @list_of_reviewers << participant #New addition | ||
| @store_needed_self_review = review #New addition |
app/models/vm_question_response.rb
Outdated
| reviews.each do |review| | ||
| review_mapping = ReviewResponseMap.find(review.map_id) | ||
| if review_mapping.present? | ||
| if review_mapping && review_mapping.present? #new addition |
app/models/vm_question_response.rb
Outdated
| @@ -91,6 +119,18 @@ def add_reviews(participant, team, vary) | |||
| add_answer(answer) | |||
| end | |||
| end | |||
| #New Addition | |||
|
Code Climate has analyzed commit fe60d46 and detected 15 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 5.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 28.7% (-19.7% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our project adds the ability see self reviews juxtaposed with peer reviews in the view my scores page(view/grades/view_team.html.erb) when seen from a students point of view if the self reviews have been enabled for that assignment.
We also display the individuals composite scores for each question in the review based on a formula that takes the input as the average peer review score of that question and self review score.
We also propose a fix for the instructor's view for the assign grade view page(view/grades/view_team.html.erb)). Here we display the peer reviews of the team and the individual self reviews of the students who are a part of that team.
Future work would be to display the composite scores as well for each student member in that team view.
Also the total composite score needs to be available as a single value. Right now the composite score is calculate for each question individually.
@team:
Ojas Barve (ovbarve@ncsu.edu)
Senthil Kumar Sankar (ssankar9@ncsu.edu)
Sandeep Ghanta (sghanta@ncsu.edu)
Abhishu Mishra (amishra6@ncsu.edu)