E1907 Refactor and improve response_controller.rb assignment on expertiza #1383

Anusha-Godavarthi · 2019-03-23T00:56:51Z

Project name : E1907 Refactor and improve response_controller.rb assignment on expertiza

Introduced temporary explaining variables in the redirect method
@Anusha-Godavarthi suggested and made the change. @mblewallenncsu and @akhilpabba reviewed it.

expertiza-bot · 2019-03-23T00:58:42Z

	1 Message
💬	Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon. This repository is being automatically checked for code quality issues using `Code Climate`. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review. If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

	✅ Yay.
✅	There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by expertiza-bot

coveralls · 2019-03-23T01:08:07Z

Coverage decreased (-17.5%) to 33.509% when pulling 74acc85 on Anusha-Godavarthi:anusha96commits into d361591 on expertiza:master.

coveralls · 2019-03-23T01:08:07Z

Coverage decreased (-17.5%) to 33.509% when pulling 74acc85 on Anusha-Godavarthi:anusha96commits into d361591 on expertiza:master.

coveralls · 2019-03-23T01:08:07Z

Coverage decreased (-0.6%) to 50.394% when pulling e8599db on Anusha-Godavarthi:anusha96commits into d361591 on expertiza:master.

expertiza-travisci-bot · 2019-03-23T01:08:18Z

Hey @Anusha-Godavarthi,
Your changes look good to me! 🎉

codeclimate · 2019-03-23T01:12:36Z

Code Climate has analyzed commit e8599db and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	8

The test coverage on the diff in this pull request is 28.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 28.9%.

View more on Code Climate.

codeclimate · 2019-03-23T16:17:39Z

app/controllers/survey_deployment_controller.rb

@@ -135,7 +136,40 @@ def model_name
    super
  end

-  # This method should be moved to survey_deployment_contoller.rb
+  def pending_surveys


Method pending_surveys has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.

codeclimate · 2019-03-23T16:17:39Z

app/controllers/survey_deployment_controller.rb

@@ -135,7 +136,40 @@ def model_name
    super
  end

-  # This method should be moved to survey_deployment_contoller.rb
+  def pending_surveys


Method pending_surveys has 27 lines of code (exceeds 25 allowed). Consider refactoring.

codeclimate · 2019-03-23T16:17:39Z

app/controllers/response_controller.rb

-      end
-    end
-  end
+


Trailing whitespace detected.

codeclimate · 2019-03-23T16:17:39Z

app/controllers/survey_deployment_controller.rb

@@ -56,6 +56,7 @@ def param_test
    params.require(:survey_deployment).permit(:questionnaire_id, :start_date, :end_date, :parent_id)
  end

+


Extra blank line detected.

codeclimate · 2019-03-23T16:17:39Z

app/controllers/survey_deployment_controller.rb

+          next unless survey_deployment && Time.now > survey_deployment.start_date && Time.now < survey_deployment.end_date
+          @surveys <<
+              [
+                  'survey' => Questionnaire.find(survey_deployment.questionnaire_id),


Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.

codeclimate · 2019-03-23T16:17:40Z

app/controllers/survey_deployment_controller.rb

@@ -135,7 +136,40 @@ def model_name
    super
  end

-  # This method should be moved to survey_deployment_contoller.rb
+  def pending_surveys


Cyclomatic complexity for pending_surveys is too high. [8/6]

codeclimate · 2019-03-23T16:17:40Z

app/controllers/survey_deployment_controller.rb

@@ -135,7 +136,40 @@ def model_name
    super
  end

-  # This method should be moved to survey_deployment_contoller.rb
+  def pending_surveys


Assignment Branch Condition size for pending_surveys is too high. [29.14/15]

codeclimate · 2019-03-23T16:17:40Z

app/controllers/survey_deployment_controller.rb

@@ -135,7 +136,40 @@ def model_name
    super
  end

-  # This method should be moved to survey_deployment_contoller.rb
+  def pending_surveys


Perceived complexity for pending_surveys is too high. [8/7]

codeclimate · 2019-03-23T16:17:40Z

app/controllers/survey_deployment_controller.rb

+        survey_deployments = survey_deployment_type.where(parent_id: p.parent_id)
+        next unless survey_deployments
+        survey_deployments.each do |survey_deployment|
+          next unless survey_deployment && Time.now > survey_deployment.start_date && Time.now < survey_deployment.end_date


Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.

codeclimate · 2019-03-23T16:17:40Z

app/controllers/survey_deployment_controller.rb

+        survey_deployments = survey_deployment_type.where(parent_id: p.parent_id)
+        next unless survey_deployments
+        survey_deployments.each do |survey_deployment|
+          next unless survey_deployment && Time.now > survey_deployment.start_date && Time.now < survey_deployment.end_date


Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.

codeclimate · 2019-03-23T16:54:06Z

app/controllers/response_controller.rb

@@ -370,4 +337,4 @@ def init_answers(questions)
      Answer.create(response_id: @response.id, question_id: q.id, answer: nil, comments: '') if a.nil?
    end
  end
-end
+end


Final newline missing.

codeclimate · 2019-03-23T18:16:56Z

app/controllers/survey_deployment_controller.rb

@@ -135,7 +134,39 @@ def model_name
    super
  end

-  # This method should be moved to survey_deployment_contoller.rb
+  def pending_surveys


Method pending_surveys has 26 lines of code (exceeds 25 allowed). Consider refactoring.

codeclimate · 2019-03-23T18:16:56Z

app/controllers/survey_deployment_controller.rb

+                  'parent_id' => p.parent_id,
+                  'participant_id' => p.id,
+                  'global_survey_id' => survey_deployment.global_survey_id
+              ]


Closing array brace must be on the same line as the last array element when opening brace is on the same line as the first array element.

codeclimate · 2019-03-23T18:16:57Z

app/controllers/survey_deployment_controller.rb

+        survey_deployments.each do |survey_deployment|
+          next unless survey_deployment && Time.current > survey_deployment.start_date && Time.current < survey_deployment.end_date
+          @surveys <<
+              [   'survey' => Questionnaire.find(survey_deployment.questionnaire_id),


Do not use space inside array brackets.

codeclimate · 2019-03-24T02:23:12Z

app/controllers/survey_deployment_controller.rb

@@ -135,7 +134,38 @@ def model_name
    super
  end

-  # This method should be moved to survey_deployment_contoller.rb
+  def pending_surveys


Assignment Branch Condition size for pending_surveys is too high. [31.06/15]

codeclimate · 2019-03-24T19:02:56Z

app/controllers/response_controller.rb

@@ -371,3 +338,4 @@ def init_answers(questions)
    end
  end
 end
+


1 trailing blank lines detected.

codeclimate · 2019-03-25T23:16:25Z

app/controllers/response_controller.rb

-  def edit_allowed?(map, user_id)
-    assignment = map.reviewer.assignment
-    # if it is a review response map, all the members of reviewee team should be able to view the reponse (can be done from heat map)
+  def view_allowed?(map, user_id)


Method view_allowed? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

codeclimate · 2019-03-25T23:16:25Z

app/controllers/response_controller.rb

-  def edit_allowed?(map, user_id)
-    assignment = map.reviewer.assignment
-    # if it is a review response map, all the members of reviewee team should be able to view the reponse (can be done from heat map)
+  def view_allowed?(map, user_id)


Cyclomatic complexity for view_allowed? is too high. [8/6]

codeclimate · 2019-03-25T23:16:25Z

app/controllers/response_controller.rb

-  def edit_allowed?(map, user_id)
-    assignment = map.reviewer.assignment
-    # if it is a review response map, all the members of reviewee team should be able to view the reponse (can be done from heat map)
+  def view_allowed?(map, user_id)


Assignment Branch Condition size for view_allowed? is too high. [30.87/15]

codeclimate · 2019-03-25T23:16:25Z

app/controllers/response_controller.rb

-    assignment = map.reviewer.assignment
-    # if it is a review response map, all the members of reviewee team should be able to view the reponse (can be done from heat map)
+  def view_allowed?(map, user_id)
+    assignment = map.reviewer.assignment # if it is a review response map, all the members of reviewee team should be able to view the reponse (can be done from heat map)


Line is too long. [170/160]

codeclimate · 2019-03-25T23:16:25Z

app/controllers/response_controller.rb

    if map.is_a? ReviewResponseMap
      reviewee_team = AssignmentTeam.find(map.reviewee_id)
      return current_user_id?(user_id) || reviewee_team.user?(current_user) || current_user.role.name == 'Administrator' ||
-        (current_user.role.name == 'Instructor' and assignment.instructor_id == current_user.id) ||
-        (current_user.role.name == 'Teaching Assistant' and TaMapping.exists?(ta_id: current_user.id, course_id: assignment.course.id))
+        (current_user.role.name == 'Instructor' and assignment.instructor_id == current_user.id) || (current_user.role.name == 'Teaching Assistant' and TaMapping.exists?(ta_id: current_user.id, course_id: assignment.course.id))


Line is too long. [227/160]

codeclimate · 2019-03-25T23:16:26Z

app/controllers/response_controller.rb

-  def edit_allowed?(map, user_id)
-    assignment = map.reviewer.assignment
-    # if it is a review response map, all the members of reviewee team should be able to view the reponse (can be done from heat map)
+  def view_allowed?(map, user_id)


Perceived complexity for view_allowed? is too high. [9/7]

Introduced temporary explaining variables in redirect method

74acc85

made changes suggested by robocop

534f0aa

Anusha Godavarthi added 2 commits March 23, 2019 11:18

changes to rectify Travis CI error

1292897

moving pending surveys to survey_deployment controller

6babab8

codeclimate bot reviewed Mar 23, 2019

View reviewed changes

made redirect changes

4feda4b

codeclimate bot reviewed Mar 23, 2019

View reviewed changes

made survey_deployment changes

a28d85c

codeclimate bot reviewed Mar 23, 2019

View reviewed changes

Anusha Godavarthi added 2 commits March 23, 2019 17:23

moved pending_survey view file

b54d876

added a test

5ba2b7e

codeclimate bot reviewed Mar 24, 2019

View reviewed changes

fixed code climate errors on response_controller

d6f9745

codeclimate bot reviewed Mar 24, 2019

View reviewed changes

Anusha Godavarthi added 6 commits March 24, 2019 15:46

further changes for pending_surveys

3b3b62b

changed spec file

64b967e

routes.rb file

a2a9b90

made changes in response_controller_spec.rb file

5bc7eb0

renamed edit_allowed

278a766

changed view_allowed

bc5e262

codeclimate bot reviewed Mar 25, 2019

View reviewed changes

Winbobob added this to the CSC517 2019 Spring OSS Projects milestone Mar 26, 2019

Anusha Godavarthi added 2 commits March 29, 2019 17:21

changed if-else to switch case

3d36d0c

code climate changes

ef17956

code climate changes 2

e8599db

Winbobob force-pushed the master branch 2 times, most recently from 4580757 to 6c27394 Compare April 21, 2019 20:24

johnbumgardner closed this May 19, 2021

Winbobob changed the title ~~Introduced temporary explaining variables in redirect method~~ E1907 Refactor and improve response_controller.rb assignment on expertiza Jun 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

E1907 Refactor and improve response_controller.rb assignment on expertiza #1383

E1907 Refactor and improve response_controller.rb assignment on expertiza #1383

Anusha-Godavarthi commented Mar 23, 2019

expertiza-bot commented Mar 23, 2019 •

edited

coveralls commented Mar 23, 2019

coveralls commented Mar 23, 2019

coveralls commented Mar 23, 2019 •

edited

expertiza-travisci-bot commented Mar 23, 2019 •

edited

codeclimate bot commented Mar 23, 2019 •

edited

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 23, 2019

codeclimate bot Mar 24, 2019

codeclimate bot Mar 24, 2019

codeclimate bot Mar 25, 2019

codeclimate bot Mar 25, 2019

codeclimate bot Mar 25, 2019

codeclimate bot Mar 25, 2019

codeclimate bot Mar 25, 2019

codeclimate bot Mar 25, 2019

		@@ -56,6 +56,7 @@ def param_test
		params.require(:survey_deployment).permit(:questionnaire_id, :start_date, :end_date, :parent_id)
		end

@@ @@ -371,3 +338,4 @@ def init_answers(questions) @@
                   end
                 end
               end

E1907 Refactor and improve response_controller.rb assignment on expertiza #1383

E1907 Refactor and improve response_controller.rb assignment on expertiza #1383

Conversation

Anusha-Godavarthi commented Mar 23, 2019

expertiza-bot commented Mar 23, 2019 • edited

coveralls commented Mar 23, 2019

coveralls commented Mar 23, 2019

coveralls commented Mar 23, 2019 • edited

expertiza-travisci-bot commented Mar 23, 2019 • edited

codeclimate bot commented Mar 23, 2019 • edited

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 23, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 24, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 24, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 25, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 25, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 25, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 25, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 25, 2019

Choose a reason for hiding this comment

codeclimate bot Mar 25, 2019

Choose a reason for hiding this comment

expertiza-bot commented Mar 23, 2019 •

edited

coveralls commented Mar 23, 2019 •

edited

expertiza-travisci-bot commented Mar 23, 2019 •

edited

codeclimate bot commented Mar 23, 2019 •

edited