#1907 Refactor response_controller

[Anusha-Godavarthi]

E1907 Refactor response_controller.rb

• Moved pending_surveys function in the response_controller.rb file to survey_deployment_controller.rb
• renamed the edit_allowed function to view_allowed in response_controller.rb
• removed assign_instance_vars section as it was not needed and combined it in edit and new sections
• removed was_submitted and changed it to prev_submitted in the create method
• added comments in the private methods
• Introduced temporary explaining variables in the redirect method
• Changed the if-else ladder in the redirect method to switch case in response_controller.rb
• Changed config/routes.rb file to reflect the changes made
• Made changes in response_controller_spec.rb

[expertiza-bot]

1 Message

💬

Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review. If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

Generated by expertiza-bot

[expertiza-travisci-bot]

Hey @Anusha-Godavarthi,
Your changes look good to me! 🎉