Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E1970. OSS project Oogie Boogie: User Experience & Confidence #1518

Closed
wants to merge 5 commits into from

Conversation

YunkaiXiao
Copy link

We started working on the issue

Please put the title of your pull request in the following format: Project ID. Name
for example, [Project id/Independent study/Issue fix/...]. project name, eg., E904. Integrating courses and assignments on Expertiza with Moodle

We suggest you include below information in your pull request:

  • A description of the changes proposed in the pull request.
  • @mentions of the person or team responsible for reviewing proposed changes.

@expertiza-bot
Copy link
Contributor

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

2 Warnings
⚠️ Your pull request is less than 50 LoC.
If you are finished refactoring the code, please consider writing corresponding tests.
⚠️ You changed MARKDOWN (*.md) documents; please double-check whether it is necessary to do so.
Alternatively, you can insert project-related content in the description field of the pull request.

Generated by expertiza-bot

@expertiza-bot
Copy link
Contributor

expertiza-bot commented Oct 16, 2019

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

4 Warnings
⚠️ Your pull request is less than 50 LoC.
If you are finished refactoring the code, please consider writing corresponding tests.
⚠️ There are code changes, but no corresponding tests.
Please include tests if this PR introduces any modifications in behavior.
⚠️ You changed MARKDOWN (*.md) documents; please double-check whether it is necessary to do so.
Alternatively, you can insert project-related content in the description field of the pull request.
⚠️ You changed YAML (*.yml) or example (*.yml.example) files; please double-check whether this is necessary.
You should commit changes to the DB schema (db/schema.rb) only if you have created new DB migrations.
Please double check your code. If you did not aim to change the DB, please revert the DB schema changes.

Generated by expertiza-bot

@coveralls
Copy link

coveralls commented Oct 16, 2019

Coverage Status

Coverage increased (+3.9%) to 34.334% when pulling 88963a4 on YunkaiXiao:master into 02c0cfa on expertiza:master.

@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Oct 16, 2019

Hey @YunkaiXiao,
Your changes look good to me! 🎉

@codeclimate
Copy link

codeclimate bot commented Oct 19, 2019

Code Climate has analyzed commit 88963a4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 29.7% (-21.8% change).

View more on Code Climate.

@YunkaiXiao
Copy link
Author

This is the wrong pull request towards master branch, check the other one towards beta branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants