Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E1947. Refactor quiz_questionnaire_controller.rb #1531

Merged
merged 24 commits into from Jun 28, 2020

Conversation

shalinshal
Copy link
Contributor

Please put the title of your pull request in the following format: Project ID. Name
for example, [Project id/Independent study/Issue fix/...]. project name, eg., E904. Integrating courses and assignments on Expertiza with Moodle

We suggest you include below information in your pull request:

  • A description of the changes proposed in the pull request.
  • @mentions of the person or team responsible for reviewing proposed changes.

@expertiza-bot
Copy link
Contributor

expertiza-bot commented Oct 18, 2019

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

✅ Good on 'ya.
One or more of your tests do not have expectations or you commented out some expectations.
To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please write at least one expectation for each test and do not comment out expectations.
Your pull request is less than 50 LoC.
If you are finished refactoring the code, please consider writing corresponding tests.
There are code changes, but no corresponding tests.
Please include tests if this PR introduces any modifications in behavior.

Generated by expertiza-bot

@coveralls
Copy link

coveralls commented Oct 18, 2019

Coverage Status

Coverage decreased (-3.3%) to 27.162% when pulling 5213989 on shalinshal:beta into 28eb0da on expertiza:beta.

@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Oct 18, 2019

Hey @shalinshal,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

@adityag3 adityag3 merged commit 6d8adc6 into expertiza:beta Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants