E2003, Refactor Assessment 360 Controller

app/controllers/assessment360_controller.rb

@@ -15,10 +15,7 @@ def all_students_all_reviews
     course = Course.find(params[:course_id])
     @assignments = course.assignments.reject(&:is_calibrated).reject {|a| a.participants.empty? }
     @course_participants = course.get_participants
-    if @course_participants.empty?
-      flash[:error] = "There is no course participant in course #{course.name}"
-      redirect_to(:back)
-    end
+    insure_existence_of(@course_participants)
     # hashes for view
     @meta_review = {}
     @teammate_review = {}
@@ -59,21 +56,28 @@ def all_students_all_reviews
                                                    @meta_review_info_per_stu)
       end
       # calculate average grade for each student on all assignments in this course
-      if @teammate_review_info_per_stu[1] > 0
-        temp_avg_grade = @teammate_review_info_per_stu[0] * 1.0 / @teammate_review_info_per_stu[1]
-        @teammate_review[cp.id][:avg_grade_for_assgt] = temp_avg_grade.round.to_s + '%'
-      end
-      if @meta_review_info_per_stu[1] > 0
-        temp_avg_grade = @meta_review_info_per_stu[0] * 1.0 / @meta_review_info_per_stu[1]
-        @meta_review[cp.id][:avg_grade_for_assgt] = temp_avg_grade.round.to_s + '%'
-      end
+      avg_review_calc_per_student(cp, @teammate_review_info_per_stu, @teammate_review)
+      avg_review_calc_per_student(cp, @meta_review_info_per_stu, @meta_review)
     end
     # avoid divide by zero error
-    @assignments.each do |assignment|
-      temp_count = @overall_teammate_review_count[assignment.id]
-      @overall_teammate_review_count[assignment.id] = 1 if temp_count.nil? or temp_count.zero?
-      temp_count = @overall_meta_review_count[assignment.id]
-      @overall_meta_review_count[assignment.id] = 1 if temp_count.nil? or temp_count.zero?
+    overall_review_count(@assignments, @overall_teammate_review_count, @overall_meta_review_count)
+  end
+
+  def overall_review_count(assignments, overall_teammate_review_count, overall_meta_review_count)
+    assignments.each do |assignment|
+      temp_count = overall_teammate_review_count[assignment.id]
+      overall_review_count_hash = 1 if temp_count.nil? or temp_count.zero?
+      temp_count = overall_meta_review_count[assignment.id]
+      overall_meta_review_count[assignment.id] = 1 if temp_count.nil? or temp_count.zero?
+    end
+  end
+
+  # Calculate the overall average review grade that a student has gotten from their teammate(s) and instructor(s)
+  def avg_review_calc_per_student(cp, review_info_per_stu, review)
+    # Check to see if the student has been given a review 
+    if review_info_per_stu[1] > 0
+      temp_avg_grade = review_info_per_stu[0] * 1.0 / review_info_per_stu[1]
+      review[cp.id][:avg_grade_for_assgt] = temp_avg_grade.round.to_s + '%'
     end
   end
 
@@ -86,49 +90,49 @@ def course_student_grade_summary
     @assignment_grades = {}
     @peer_review_scores = {}
     @final_grades = {}
-
     course = Course.find(params[:course_id])
     @assignments = course.assignments.reject(&:is_calibrated).reject {|a| a.participants.empty? }
     @course_participants = course.get_participants
-    if @course_participants.empty?
-      flash[:error] = "There is no course participant in course #{course.name}"
-      redirect_to(:back)
-    end
-
+    insure_existence_of(@course_participants)
     @course_participants.each do |cp|
       @topics[cp.id] = {}
       @assignment_grades[cp.id] = {}
       @peer_review_scores[cp.id] = {}
       @final_grades[cp.id] = 0
-
       @assignments.each do |assignment|
         user_id = cp.user_id
         assignment_id = assignment.id
-
         assignment_participant = assignment.participants.find_by(user_id: user_id)
+        # Break out of the loop if there are no participants in the assignment
         next if assignment.participants.find_by(user_id: user_id).nil?
+        # Break out of the loop if the participant has no team
+        next if TeamsUser.team_id(assignment_id, user_id).nil?
+        assignment_grade_summary(cp, assignment_id)
 
-        # A topic exists if a team signed up for a topic, which can be found via the user and the assignment
-        topic_id = SignedUpTeam.topic_id(assignment_id, user_id)
-        @topics[cp.id][assignment_id] = SignUpTopic.find_by(id: topic_id)
-
-        # Instructor grade is stored in the team model, which is found by finding the user's team for the assignment
-        team_id = TeamsUser.team_id(assignment_id, user_id)
-        next if team_id.nil?
-
-        team = Team.find(team_id)
         peer_review_score = find_peer_review_score(user_id, assignment_id)
+        next if peer_review_score.dig(:review, :scores, :avg).nil?
+        @peer_review_scores[cp.id][assignment_id] = peer_review_score[:review][:scores][:avg].round(2)
+      end
+    end
+  end
 
-        # Set the assignment grade, peer review score, and sum for the final student summary
-        @assignment_grades[cp.id][assignment_id] = team[:grade_for_submission]
-        unless @assignment_grades[cp.id][assignment_id].nil?
-          @final_grades[cp.id] += @assignment_grades[cp.id][assignment_id]
-        end
+  def assignment_grade_summary(cp, assignment_id)
+    user_id = cp.user_id
+    # A topic exists if a team signed up for a topic, which can be found via the user and the assignment
+    topic_id = SignedUpTeam.topic_id(assignment_id, user_id)
+    @topics[cp.id][assignment_id] = SignUpTopic.find_by(id: topic_id)
+    # Instructor grade is stored in the team model, which is found by finding the user's team for the assignment
+    team_id = TeamsUser.team_id(assignment_id, user_id)
+    team = Team.find(team_id)
+    @assignment_grades[cp.id][assignment_id] = team[:grade_for_submission]
+    return if @assignment_grades[cp.id][assignment_id].nil?
+    @final_grades[cp.id] += @assignment_grades[cp.id][assignment_id]
+  end
 
-        unless (peer_review_score.nil? || peer_review_score[:review][:scores][:avg].nil?)
-          @peer_review_scores[cp.id][assignment_id] = peer_review_score[:review][:scores][:avg].round(2)
-        end
-      end
+  def insure_existence_of(course_participants)
+    if course_participants.empty?
+      flash[:error] = "There is no course participant in course #{course.name}"
+      redirect_to(:back)
     end
   end