Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2020. Let course staff as well as students do reviews #1729

Closed
wants to merge 22 commits into from

Conversation

epeden
Copy link
Contributor

@epeden epeden commented Apr 21, 2020

No description provided.

Eric Peden and others added 2 commits April 20, 2020 22:08
@expertiza-bot
Copy link
Contributor

expertiza-bot commented Apr 21, 2020

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

1 Warning
⚠️ In your tests, there are many expectations of elements on pages, which is good.
To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please write more expectations to validate other things, such as database records, dynamically generated contents.
There are code changes, but no corresponding tests.
Please include tests if this PR introduces any modifications in behavior.

Generated by expertiza-bot

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.3%) to 28.178% when pulling 56cb28e on epeden:beta into caf4c6c on expertiza:beta.

@coveralls
Copy link

coveralls commented Apr 21, 2020

Coverage Status

Coverage increased (+11.01%) to 41.493% when pulling c684bc7 on epeden:beta into caf4c6c on expertiza:beta.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.3%) to 28.178% when pulling 56cb28e on epeden:beta into caf4c6c on expertiza:beta.

@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Apr 21, 2020

Hey @epeden,
Your changes look good to me! 🎉

Hosung Hwang and others added 18 commits April 22, 2020 19:23
E2020. Course staff reviews can be visually recognized by authors
…iew-mapping-controllers

add RSpec tests for assignment and review_mapping controllers
fix view_team view so instructors can see names of reviews done by in…
use review deadline instead of submission
@Winbobob
Copy link
Member

Winbobob commented Sep 6, 2020

/rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants