E2064. Refactor reputation_web_service_controller.rb

[uahamedncsu]

Expertiza allows student work to be peer-reviewed, since peers can provide more feedback than the instructor can. However, if we want to assure that all students receive competent feedback, or even use peer-assigned grades, we need a way to judge which peer reviewers are most credible. The solution is the reputation system. Reputation systems have been deployed as web services, peer-review researchers will be able to use them to calculate scores on assignments, both past and present (past data can be used to tune the algorithms).
For this project, our team's job is to refactor the file: reputation_web_service_controller.rb. This file is the controller to calculate the reputation scores. A “reputation” measures how close a reviewer’s scores are to other reviewers’ scores. This controller implements the calculation of reputation scores.

@uahamedncsu
@abhishekgupta930
@srcapezza

[expertiza-bot]

1 Message

💬

Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon. This repository is being automatically checked for code-quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review. Also, please spend some time looking at the instructions at the top of your course project writeup. If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

UUID		2 Warnings
9643	⚠️	The should syntax is deprecated in RSpec 3. Please use expect syntax instead. Even in test descriptions, please avoid using should.
e29c	⚠️	One or more of your test expectations do not have matchers. To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please include matchers, such as comparisons (e.g., equal(expected_value)), the status change of objects (e.g., change(object, :value).by(delta)), error handlings (e.g., raise_error("message")).
c951	✅	You should commit changes to the DB schema (db/schema.rb) only if you have created new DB migrations. Please double check your code. If you did not aim to change the DB, please revert the DB schema changes.
0a9c	✅	You are using global variables ($) or class variables (@@); please double-check whether this is necessary.
be55	✅	There are one or more skipped/pending/focused test cases in your pull request. Please fix them.
ecaa	✅	There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.
e222	✅	Your pull request is more than 500 LoC. Please make sure you did not commit unnecessary changes, such as schema.rb, node_modules, change logs.
4f9c	✅	You are requiring rspec gem, fixture-related gem(s) or different helper methods in RSpec tests. There have already been included, you do not need to require them again. Please remove them.
7671	✅	Your pull request touches more than 30 files. Please make sure you did not commit unnecessary changes, such as node_modules, change logs.
846d	✅	Your pull request has many duplicated commit messages. Please try to squash similar commits. And using meaningful commit messages later.
7d1a	✅	This pull request contains TODO or FIXME task(s); please fix them.
899a	✅	You changed MARKDOWN (*.md) documents; please double-check whether it is necessary to do so. Alternatively, you can insert project-related content in the description field of the pull request.
d699	✅	You changed YAML (*.yml) or example (*.yml.example) files; please double-check whether this is necessary.
b22a	✅	You modified vendor folder, please double-check whether it is necessary.
04af	✅	One or more of your tests do not have expectations or you commented out some expectations. To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please write at least one expectation for each test and do not comment out expectations.

UUID		✅ Jolly good show.
65de	✅	You are including debug code in your pull request, please remove it.

Generated by expertiza-bot

[coveralls]

Coverage increased (+1.6%) to 46.059% when pulling 0df8089 on srcapezza:beta into e110875 on expertiza:beta.

[expertiza-travisci-bot]

Hey @uahamedncsu,
Your changes look good to me! 🎉