Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2083 Revision planning tool E2016 #1832

Closed
wants to merge 45 commits into from

Conversation

SidharthMehta
Copy link
Contributor

CSC/ECE 517 Fall 2020 - E2083 Revision planning tool E2016

What it does: In the first round of Expertiza reviews, we ask reviewers to give authors some guidance on how to improve their work. Then in the second round, reviewers rate how well authors have followed their suggestions. We could carry the interaction one step further if we asked authors to make up a revision plan based on the first-round reviews. That is, authors would say what they were planning to do to improve their work. Then second-round reviewers would assess how well they did it. In essence, this means that authors would be adding criteria to the second-round rubric that applied only to their submission. We are interested in having this implemented and used in a class so that we can study its effect.

@chaitanyamehta
@SidharthMehta
@demadewe
@vickyyang5454

@expertiza-bot
Copy link
Contributor

expertiza-bot commented Nov 1, 2020

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

6 Warnings
1 ⚠️ Your pull request is more than 500 LoC.
Please make sure you did not commit unnecessary changes, such as schema.rb, node_modules, change logs.
2 ⚠️ Your pull request touches more than 30 files.
Please make sure you did not commit unnecessary changes, such as node_modules, change logs.
3 ⚠️ You are using global variables ($) or class variables (@@); please double-check whether this is necessary.
4 ⚠️ Using create in unit tests or integration tests may be overkill. Try to use build or double instead.
5 ⚠️ You modified spec/factories/ folder; please double-check whether it is necessary.
6 ⚠️ One or more of your tests do not have expectations or you commented out some expectations.
To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please write at least one expectation for each test and do not comment out expectations.
7 There are code changes, but no corresponding tests.
Please include tests if this PR introduces any modifications in behavior.
8 Your pull request is less than 50 LoC.
If you are finished refactoring the code, please consider writing corresponding tests.
9 You changed MARKDOWN (*.md) documents; please double-check whether it is necessary to do so.
Alternatively, you can insert project-related content in the description field of the pull request.

Generated by expertiza-bot

@coveralls
Copy link

coveralls commented Nov 1, 2020

Coverage Status

Coverage increased (+12.2%) to 55.168% when pulling 35a8a84 on SidharthMehta:beta into 69a8436 on expertiza:beta.

@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Nov 1, 2020

Hey @SidharthMehta,
Your changes look good to me! 🎉

@SidharthMehta SidharthMehta changed the title Make temporary change to create PR E2083 Revision planning tool E2016 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants