Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2100. Tagging report for Students #1895

Merged
merged 82 commits into from
May 19, 2021
Merged

E2100. Tagging report for Students #1895

merged 82 commits into from
May 19, 2021

Conversation

smdupor
Copy link
Contributor

@smdupor smdupor commented Mar 5, 2021

Changes:
-- Changed comment structure in app/assets/javascripts/answer_tags.js to set up initial commit for:

TeamTuffy CSC/ECE517 Spring '21. Contributing Team Members Were:

-- jcui9: Jialin Cui
-- smdupor: Stevan Dupor
--jmhurst: Jason Hurst

Mentor: Anuja Kulkarni

@expertiza-bot
Copy link
Contributor

expertiza-bot commented Mar 5, 2021 •
edited

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.
UUID ✅ Good on 'ya.
61df ✅ Your pull request is less than 50 LoC.
If you are finished refactoring the code, please consider writing corresponding tests.
ecaa ✅ There are code changes, but no corresponding tests.
Please include tests if this PR introduces any modifications in behavior.
e222 ✅ Your pull request is more than 500 LoC.
Please make sure you did not commit unnecessary changes, such as schema.rb, node_modules, change logs.

Generated by expertiza-bot

@coveralls
Copy link

coveralls commented Mar 5, 2021 •
edited

Coverage Status

Coverage remained the same at 46.471% when pulling fb224ed on smdupor:beta into 3b90473 on expertiza:beta.

@coveralls
Copy link

Coverage Status

Coverage decreased (-25.4%) to 32.054% when pulling b518cb2 on smdupor:beta into 0ee6d30 on expertiza:beta.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-25.4%) to 32.054% when pulling b518cb2 on smdupor:beta into 0ee6d30 on expertiza:beta.

@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Mar 5, 2021 •
edited

Hey @smdupor,
Your changes look good to me! 🎉

@Winbobob
Copy link
Member

Winbobob commented Mar 6, 2021

/cancel ecaa

@expertiza-bot
Copy link
Contributor

Your request has been accepted by the bot. Please wait, it can take up to 10 min to process the request.

@Winbobob
Copy link
Member

Winbobob commented Mar 7, 2021

We do not require tests for UI changes right now.

smdupor and others added 18 commits March 7, 2021 11:52
@smdupor
Enable Show/Hide of Tag HeatGrid from toggle button; Hide on Load if …
134b9c3 
…no tags or if tags all done.
@smdupor
Fixed #7 Move majority of new JS code into view_team_in_grades.js fro…
8f4636d 
…m top of view_team.html.erb.
@jmhurst1
CSS change for heatgrid
82aa77b
@jmhurst1
Updated comment
47e6dff
@jmhurst1
Added css to updateTable in addition to generateTable
306d0f0
@jmhurst1
First table CSS changes
cf4adfc
@JialinC @smdupor
Implemented tag counters and display on page.
5b3748b
@jmhurst1 @smdupor
CSS change for heatgrid
1e3b8e5
@jmhurst1 @smdupor
Updated comment
eef4c30
@jmhurst1 @smdupor
Added css to updateTable in addition to generateTable
be7bfcc
@jmhurst1 @smdupor
First table CSS changes
0bf8602
@smdupor
Add new tag counting algorithm that counts by question and review num…
6f66dda 
…ber, and populates heatgrid with tagless reviews in c0 grey style.
@smdupor
Deleted deprecated heatgrid functions in view_team_in_grades.js
e28bbe6
@smdupor
Clean up comments and remove commented-out debug code from countTags(…
4cb3cf0 
…) and drawTagGrid()
@jmhurst1
Added more CSS style inputs for table
15a8500
@jmhurst1
Merge branch 'beta' into jmhurst/Heatgrid_Table_CSS
b34c67c
@smdupor
Make heatgrid sizing more flexible for future changes in number / typ…
481cdd1 
…e of toggle-able tags.
@smdupor
Revise heading of heatgrid table text -- ReviewTags Completed.
8645409
smdupor and others added 16 commits March 17, 2021 20:12
@smdupor
New tests for Javascript calls and HTML elements in view_team.html.erb
3923832
@smdupor
Change heatgrid header to two rows to support # out of # and scale wi…
1cda9c5 
…th table width.
@smdupor
Change heatgrid tooltip text to consistent capitalization, punctuation
f37fa81
@smdupor
Refactor html data- attribs to use correct style, clean up whitespace
404084c
@smdupor
Fix layout issue with Question Toggle zebra table jumping below tag g…
c97279c 
…rid.
@smdupor
Fix round counting bug in Round # Question # Rows
9dcd8d9
@smdupor
Clean up unnecessary comments in view_team_in_grades.js
50af631
@smdupor
Address reviews-not-rendering bug in view_team.html.erb introduced by…
7aacd64 
… E-2084
@smdupor
Update grades controller spec to expect testing round [1, 2] instead …
6dcbcdb 
…of only round 2
@smdupor
Update grades controller spec to expect testing round [1,2] instead o…
212f3b9 
…f only round 2
@smdupor
Merge remote-tracking branch 'origin/beta' into beta
43278b7
@jmhurst1
Added link
463e445
@jmhurst1
Hides info when no reviews to tag
382d4c4
@smdupor
Merge pull request #49 from smdupor/jmhurst/Added_link_to_main
02c4b55 
Added link
@smdupor
Split oversized <td <%= ruby %>> tag on line 178 of view_team.html.er…
c7e9406 
…b into 3 lines.
@smdupor
Delete unused stub function collapseHeatGrid() in view_team_in_grades.js
5de6565
@Winbobob
Copy link
Member

/cancel e222

@expertiza-bot
Copy link
Contributor

Your request has been accepted by the bot. Please wait, it can take up to 10 min to process the request.

@Winbobob
Copy link
Member

Hi @smdupor, @jmhurst1, and @JialinC, please trigger the Travis CI again, then you should see the last warning mentioned by the bot be canceled.

@johnbumgardner johnbumgardner merged commit ec2e1ca into expertiza:beta May 19, 2021
@duhaoze11 duhaoze11 mentioned this pull request Oct 4, 2021
Closed
@smdupor smdupor mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CSC517 2021 Spring OSS Projects
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@smdupor @expertiza-bot @coveralls @expertiza-travisci-bot @Winbobob @johnbumgardner @jmhurst1 @JialinC