Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2106. Fix view in student_task/list page #1903

Merged
merged 6 commits into from May 19, 2021

Conversation

sharathKV
Copy link
Contributor

Initial Changes done in app/views/student_task/list.html.erb:
Fix the ugly gap between two divs
Testing pull request

Team_3848 ECE 517 Spring 2021. Contributing team members:
Sharath Kumar: svkumar2
Nikhil Sundaraswamy: nsundar

Mentor: Saurabh Shingte

@expertiza-bot
Copy link
Contributor

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

UUID 2 Warnings
61df ⚠️ Your pull request is less than 50 LoC.
If you are finished refactoring the code, please consider writing corresponding tests.
ecaa ⚠️ There are code changes, but no corresponding tests.
Please include tests if this PR introduces any modifications in behavior.

Generated by expertiza-bot

@expertiza-bot
Copy link
Contributor

expertiza-bot commented Mar 15, 2021

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

UUID ✅ Woo!
61df Your pull request is less than 50 LoC.
If you are finished refactoring the code, please consider writing corresponding tests.
ecaa There are code changes, but no corresponding tests.
Please include tests if this PR introduces any modifications in behavior.
UUID ✅ Good on 'ya.
65de You are including debug code in your pull request, please remove it.

Generated by expertiza-bot

@coveralls
Copy link

Coverage Status

Coverage decreased (-12.8%) to 33.646% when pulling 92f3c15 on sharathKV:beta into 3b90473 on expertiza:beta.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-12.8%) to 33.646% when pulling 92f3c15 on sharathKV:beta into 3b90473 on expertiza:beta.

@coveralls
Copy link

coveralls commented Mar 15, 2021

Coverage Status

Coverage decreased (-0.04%) to 46.427% when pulling c4f02b3 on sharathKV:beta into 3b90473 on expertiza:beta.

@Saurabh110 Saurabh110 changed the title E2106. Beautify the appearance of task_list page by adjusting divs E2106. Fix view in student_task/list page Mar 16, 2021
@Winbobob
Copy link
Member

/cancel ecaa

@expertiza-bot
Copy link
Contributor

Your request has been accepted by the bot. Please wait, it can take up to 10 min to process the request.

@Winbobob
Copy link
Member

We do not require to write tests for UI changes.

@Winbobob
Copy link
Member

/cancel 61df

@expertiza-bot
Copy link
Contributor

Your request has been accepted by the bot. Please wait, it can take up to 10 min to process the request.

@Winbobob
Copy link
Member

Hi @sharathKV, please trigger the Travis CI again, then you should see the 2 warnings mentioned by the bot be cancelled.

@expertiza-travisci-bot
Copy link

expertiza-travisci-bot commented Mar 20, 2021

Hey @sharathKV,
Your changes look good to me! 🎉

@Nikhil1220
Copy link
Contributor

Have added checkbox to the publishing rights column

@johnbumgardner johnbumgardner merged commit fd1be5f into expertiza:beta May 19, 2021
@duhaoze11 duhaoze11 mentioned this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants