Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2245: View for results of bidding #2392

Merged
merged 86 commits into from Apr 30, 2022
Merged

E2245: View for results of bidding #2392

merged 86 commits into from Apr 30, 2022

Conversation

dnguyenv
Copy link
Contributor

@dnguyenv dnguyenv commented Apr 24, 2022 •
edited

Quick description about changes proposed in this pull request: This pull request is to fulfill the requirement of implementing a feature to enable Instructor role to view result of bidding process for a particular assignment topics

Changes details:

  • Added additional partials to the views to show bidding metrics like total # of bids, # of #1 bids, # of #2 bids, etc
  • A pop-up/tool-tip view for the Instructor to hover over the team(s) that assigned to a topic and see informative metrics
  • Code to calculate the required metrics
  • Enhancement in the Assignment >> Topics view to remove Bookmark column when it's disabled
  • Test cases for the changes

Duy Van Nguyen and others added 30 commits March 10, 2022 21:45
remove unnecessary code
0b06145
naive fix for first time launch
50542c0
@dnguyenv
naive fix for first time launch
cd4a53d
@dnguyenv
update spec
a7db7a0
@dnguyenv
Add markup_styles_controller spec test structure
23f2da7
@dnguyenv
add test to list, show and default settings
ae60d87
@jojo463711
Merge pull request #1 from dnguyenv/duyhard
4abc1dd 
Add more test content to the markup_styles_controller_spec
@dnguyenv
Fix #show test case
54b73db
@dnguyenv
fix show test case
91bfc75
@dnguyenv
Merge pull request #2 from dnguyenv/duyhard
d32cce4 
Enable RSpec test case to run against show method of markup_styles_controller_spec.rb
@dnguyenv
Fix local variable name for passing test cases
5ee4f38
@dnguyenv
Add all remaining test cases for markup_styles_controller
5fea9d5
@dnguyenv
Fixes for #destroy and #update test cases
9640565
@dnguyenv
Fixes for #destroy and #update test cases
4988175
@dnguyenv
fix typo for #update case
97d2ba3
@dnguyenv
Update #update and #create test cases
55d2bb9
@dnguyenv
update #update and #edit cases
ab190e0
@dnguyenv
update fake list
07dab3d
@dnguyenv
fix render page
03c6031
@dnguyenv
enhance #list case
cb44f8c
@dnguyenv
enhance #list case
e951641
@dnguyenv
enhance #list case
0876f01
@dnguyenv
enhance #list case
cc20a66
@dnguyenv
enhance #list case
7e63797
@dnguyenv
Merge pull request #3 from dnguyenv/duyhard
0443420 
Create all remaining test cases for markup_styles_controller
@dnguyenv
Merge branch 'beta' of github.com:expertiza/expertiza into duyhard
3db2a20
@dnguyenv
add more test case for lockable
d8c7777
@dnguyenv
update lock controller test
8d907d4
@dnguyenv
fix the factory
3af3213
@dnguyenv
fix the factory
c7ef9fc
dnguyenv and others added 16 commits April 1, 2022 18:29
@dnguyenv
Merge branch 'beta' of https://github.com/expertiza/expertiza into beta
9da8226
@dnguyenv
merged with upstream beta
a3c6331
initialize views with place holders
74c1d0a
Merge branch 'beta' of github.com:dnguyenv/expertiza into beta
1592a08
enable bids metrics for instructor only
0c5a965
Merge branch 'beta' of github.com:dnguyenv/expertiza into beta
85fe689
@salekinsirajus
WIP: total # of bids, initial version shows numbers from the database
25d099c
@salekinsirajus
Added logic for #1 and #2 choices. TODO: are the priorities 0 or 1-in…
fd67c3f 
…dexed?, is this the only page where this data will be displayed?
@salekinsirajus
fixed silly errors:
c49a7fc 
1. number_one and number_two fetches count of
2. Using the right hash to collect and display data
Update views to remove Bookmark column if disabled
0928989
Merge branch 'beta' of github.com:dnguyenv/expertiza into beta
cfa7a9d
Implemented hover tooltip showing team bid ordering
416d47a
@salekinsirajus
Moved query logic for total bids and number one, number two choices i…
29be19a 
…nto the relevant partials
@salekinsirajus
Added check for whether bidding is active (is_intelligent) before dis…
fe34e56 
…playing total bids and priorities
remove bookmarks disabling logic and hi_IN local values
9a887fb
remove intelligent check at partial level
734233f
@coveralls
Copy link

coveralls commented Apr 25, 2022 •
edited

Coverage Status

Coverage decreased (-0.05%) to 51.089% when pulling b07aba8 on dnguyenv:beta into 44cbab0 on expertiza:beta.

@coveralls
Copy link

Coverage Status

Coverage decreased (-34.0%) to 17.178% when pulling 734233f on dnguyenv:beta into 44cbab0 on expertiza:beta.

@expertiza-travisci-bot
Copy link

Hey @dnguyenv,
Your changes look good to me! 🎉

@dnguyenv dnguyenv changed the title [WIP-Don't merge] E2245: View for results of bidding E2245: View for results of bidding Apr 26, 2022
@johnbumgardner johnbumgardner merged commit 91d6286 into expertiza:beta Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dnguyenv @coveralls @expertiza-travisci-bot @johnbumgardner @jojo463711 @namanshrimali @salekinsirajus