Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2245: View for results of bidding #2392

Merged
merged 86 commits into from
Apr 30, 2022
Merged

E2245: View for results of bidding #2392

merged 86 commits into from
Apr 30, 2022

Commits on Mar 11, 2022

  1. remove unnecessary code

    Duy Van Nguyen committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    0b06145 View commit details
    Browse the repository at this point in the history

  2. naive fix for first time launch

    Duy Van Nguyen committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    50542c0 View commit details
    Browse the repository at this point in the history

  3. naive fix for first time launch

    @dnguyenv
    dnguyenv committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    cd4a53d View commit details
    Browse the repository at this point in the history

  4. update spec

    @dnguyenv
    dnguyenv committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    a7db7a0 View commit details
    Browse the repository at this point in the history

  5. Add markup_styles_controller spec test structure

    @dnguyenv
    dnguyenv committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    23f2da7 View commit details
    Browse the repository at this point in the history

  6. add test to list, show and default settings

    @dnguyenv
    dnguyenv committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    ae60d87 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #1 from dnguyenv/duyhard 

    Add more test content to the markup_styles_controller_spec
    @jojo463711
    jojo463711 committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    4abc1dd View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2022

  1. Fix #show test case

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    54b73db View commit details
    Browse the repository at this point in the history

  2. fix show test case

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    91bfc75 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from dnguyenv/duyhard 

    Enable RSpec test case to run against show method of markup_styles_controller_spec.rb
    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    d32cce4 View commit details
    Browse the repository at this point in the history

  4. Fix local variable name for passing test cases

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    5ee4f38 View commit details
    Browse the repository at this point in the history

  5. Add all remaining test cases for markup_styles_controller

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    5fea9d5 View commit details
    Browse the repository at this point in the history

  6. Fixes for #destroy and #update test cases

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    9640565 View commit details
    Browse the repository at this point in the history

  7. Fixes for #destroy and #update test cases

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    4988175 View commit details
    Browse the repository at this point in the history

  8. fix typo for #update case

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    97d2ba3 View commit details
    Browse the repository at this point in the history

  9. Update #update and #create test cases

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    55d2bb9 View commit details
    Browse the repository at this point in the history

  10. update #update and #edit cases

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    ab190e0 View commit details
    Browse the repository at this point in the history

  11. update fake list

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    07dab3d View commit details
    Browse the repository at this point in the history

  12. fix render page

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    03c6031 View commit details
    Browse the repository at this point in the history

  13. enhance #list case

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    cb44f8c View commit details
    Browse the repository at this point in the history

  14. enhance #list case

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    e951641 View commit details
    Browse the repository at this point in the history

  15. enhance #list case

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    0876f01 View commit details
    Browse the repository at this point in the history

  16. enhance #list case

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    cc20a66 View commit details
    Browse the repository at this point in the history

  17. enhance #list case

    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    7e63797 View commit details
    Browse the repository at this point in the history

  18. Merge pull request #3 from dnguyenv/duyhard 

    Create all remaining test cases for markup_styles_controller
    @dnguyenv
    dnguyenv committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    0443420 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Merge branch 'beta' of github.com:expertiza/expertiza into duyhard

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    3db2a20 View commit details
    Browse the repository at this point in the history

  2. add more test case for lockable

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    d8c7777 View commit details
    Browse the repository at this point in the history

  3. update lock controller test

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    8d907d4 View commit details
    Browse the repository at this point in the history

  4. fix the factory

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    3af3213 View commit details
    Browse the repository at this point in the history

  5. fix the factory

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    c7ef9fc View commit details
    Browse the repository at this point in the history

  6. fix the lock testcase

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    b8e1c71 View commit details
    Browse the repository at this point in the history

  7. fix the lock testcase

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    06e3111 View commit details
    Browse the repository at this point in the history

  8. fix the lock testcase

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    017340e View commit details
    Browse the repository at this point in the history

  9. fix the lock testcase

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    b77507b View commit details
    Browse the repository at this point in the history

  10. fix the lock testcase

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    c4e2265 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #4 from dnguyenv/duyhard 

    Update test cases for lock_controller
    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    d6826e3 View commit details
    Browse the repository at this point in the history

  12. remove bootstrap quick fix

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    435a27e View commit details
    Browse the repository at this point in the history

  13. Merge branch 'duyhard' into beta

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    42ac125 View commit details
    Browse the repository at this point in the history

  14. reverse application.html.erb

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    df07b19 View commit details
    Browse the repository at this point in the history

  15. add more case for markup styles

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    ee88b7f View commit details
    Browse the repository at this point in the history

  16. reverse to upstream beta app

    @dnguyenv
    dnguyenv committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    6edf88e View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. Empty commit to trigger Travis

    @dnguyenv
    dnguyenv committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    70dd7f8 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2022

  1. Add more comments to the test cases

    @dnguyenv
    dnguyenv committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    f89740c View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2022

  1. Updated bootstrap-sass version to fix sass issue (expertiza#2310)

    @namanshrimali @dnguyenv
    namanshrimali authored and dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    45b86c6 View commit details
    Browse the repository at this point in the history

  2. add more test case for lockable

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    16f808d View commit details
    Browse the repository at this point in the history

  3. update lock controller test

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    91c9f25 View commit details
    Browse the repository at this point in the history

  4. fix the factory

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    5c46e97 View commit details
    Browse the repository at this point in the history

  5. fix the factory

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    5f7cf4c View commit details
    Browse the repository at this point in the history

  6. fix the lock testcase

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    1d49505 View commit details
    Browse the repository at this point in the history

  7. fix the lock testcase

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    e337a29 View commit details
    Browse the repository at this point in the history

  8. fix the lock testcase

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    f0cb75a View commit details
    Browse the repository at this point in the history

  9. fix the lock testcase

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    9b2d012 View commit details
    Browse the repository at this point in the history

  10. fix the lock testcase

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    532af33 View commit details
    Browse the repository at this point in the history

  11. remove bootstrap quick fix

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    7f39818 View commit details
    Browse the repository at this point in the history

  12. reverse application.html.erb

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    6165d3c View commit details
    Browse the repository at this point in the history

  13. add more case for markup styles

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    d703ad3 View commit details
    Browse the repository at this point in the history

  14. reverse to upstream beta app

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    0ac9200 View commit details
    Browse the repository at this point in the history

  15. Empty commit to trigger Travis

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    13e01cd View commit details
    Browse the repository at this point in the history

  16. Add more comments to the test cases

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    a206c53 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'beta' of github.com:dnguyenv/expertiza into beta

    @dnguyenv
    dnguyenv committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    ec28889 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. fix typo in comments

    @dnguyenv
    dnguyenv committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    4d3f80f View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. Merge branch 'beta' of https://github.com/expertiza/expertiza into beta

    @dnguyenv
    dnguyenv committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    9da8226 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. merged with upstream beta

    @dnguyenv
    dnguyenv committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    a3c6331 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. initialize views with place holders

    Duy Nguyen committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    74c1d0a View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. Merge branch 'beta' of github.com:dnguyenv/expertiza into beta

    David Glymph committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    1592a08 View commit details
    Browse the repository at this point in the history

  2. enable bids metrics for instructor only

    Duy Nguyen committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    0c5a965 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'beta' of github.com:dnguyenv/expertiza into beta

    David Glymph committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    85fe689 View commit details
    Browse the repository at this point in the history

  4. WIP: total # of bids, initial version shows numbers from the database

    @salekinsirajus
    salekinsirajus committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    25d099c View commit details
    Browse the repository at this point in the history

  5. Added logic for #1 and #2 choices. TODO: are the priorities 0 or 1-in… 

    …dexed?, is this the only page where this data will be displayed?
    @salekinsirajus
    salekinsirajus committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    fd67c3f View commit details
    Browse the repository at this point in the history

  6. fixed silly errors: 

    1. number_one and number_two fetches count of
2. Using the right hash to collect and display data
    @salekinsirajus
    salekinsirajus committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    c49a7fc View commit details
    Browse the repository at this point in the history

  7. Update views to remove Bookmark column if disabled

    Duy Nguyen committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    0928989 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Merge branch 'beta' of github.com:dnguyenv/expertiza into beta

    David Glymph committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    cfa7a9d View commit details
    Browse the repository at this point in the history

  2. Implemented hover tooltip showing team bid ordering

    David Glymph committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    416d47a View commit details
    Browse the repository at this point in the history

  3. Moved query logic for total bids and number one, number two choices i… 

    …nto the relevant partials
    @salekinsirajus
    salekinsirajus committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    29be19a View commit details
    Browse the repository at this point in the history

  4. Added check for whether bidding is active (is_intelligent) before dis… 

    …playing total bids and priorities
    @salekinsirajus
    salekinsirajus committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    fe34e56 View commit details
    Browse the repository at this point in the history

  5. remove bookmarks disabling logic and hi_IN local values

    Duy Nguyen committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    9a887fb View commit details
    Browse the repository at this point in the history

  6. remove intelligent check at partial level

    Duy Nguyen committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    734233f View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. enable/disable bids metrics based on role

    Duy Nguyen committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    aea30cb View commit details
    Browse the repository at this point in the history

  2. fixed bookmark table header, was still showing when bookmarks were di… 

    …sabled
    David Glymph committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    bdc1c60 View commit details
    Browse the repository at this point in the history

  3. cleaned up get_team_bids, added instructor check

    David Glymph committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    f4d88fe View commit details
    Browse the repository at this point in the history

  4. rubocop fixes

    David Glymph committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    b9cc3f4 View commit details
    Browse the repository at this point in the history

  5. fix bookmark view

    Duy Nguyen committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    caa129c View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. add test for sign_up_sheet_helper_spec.rb

    Duy Nguyen committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    e31806f View commit details
    Browse the repository at this point in the history

  2. Add comment to reason the bidding metrics on sign-up-sheet table

    Duy Nguyen committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    27ee388 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2022

  1. minor refactor

    @johnbumgardner
    johnbumgardner committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    ca92523 View commit details
    Browse the repository at this point in the history

  2. clean up a little

    @johnbumgardner
    johnbumgardner committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    b07aba8 View commit details
    Browse the repository at this point in the history