Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2256: Refactor late_policies_controller.rb #2466

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

kalgeekotak99
Copy link

@kalgeekotak99 kalgeekotak99 commented Oct 25, 2022

Issues Worked Upon:

  • Rename all usages of @penalty_policy to @late_policy within the controller as well as the views
  • Refactor the method “duplicate_name_check” such that it doesn’t violate the Single Responsibility Principle.
  • Use a better name than “duplicate_name_check”
  • Make the validate_input method as “stateless” as possible.
  • Update the code so that initially you assume that the penalty is NOT VALID, and then you need to verify that it is valid during validation.
  • Fix the Error Message output. It currently prints only one error message even if more than one validation is failing.

@expertiza-travisci-bot
Copy link

Hey @kalgeekotak99,
Your changes look good to me! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants