Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2256: Refactor late_policies_controller.rb #2466

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

E2256: Refactor late_policies_controller.rb #2466

wants to merge 33 commits into from

Commits on Oct 14, 2022

  1. @aramasw,@nmurali2 : Refactor penalty_policy to late_policy

    @kkotak99
    kkotak99 committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    61b01fa View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Merge pull request #1 from NitishKumar2404/beta 

    Rename @penalty_policy to @late_policy
    @aramasw
    aramasw committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    1f936f9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'expertiza:main' into main

    @kalgeekotak99
    kalgeekotak99 committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    a053eec View commit details
    Browse the repository at this point in the history

  3. Testing write permissions

    Ashrita Ramaswamy committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    e48643b View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. Testing write connection

    @aramasw
    aramasw committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    d75b67c View commit details
    Browse the repository at this point in the history

  2. Pair programming with @kalgeekotak99 : Remove params from validate_in… 

    …put method
    root committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    3041ba0 View commit details
    Browse the repository at this point in the history

  3. @kalgeekotak99 , @aramasw : Fix build issues

    @aramasw
    aramasw committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    1e021cf View commit details
    Browse the repository at this point in the history

  4. @kalgeekotak99 , @aramasw : Refactor duplicate_name_check method into… 

    … check_if_policy_name_exists_on_update and check_if_policy_name_exists
    @aramasw
    aramasw committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    42255e8 View commit details
    Browse the repository at this point in the history

  5. @kalgeekotak99 @aramasw : Fix Build Issues

    @aramasw
    aramasw committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    cf04118 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. @aramasw : Remove redundant variable

    @kalgeekotak99
    kalgeekotak99 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    0751d74 View commit details
    Browse the repository at this point in the history

  2. @kkotak @aramasw : remove model object from function parameter and in… 

    …stead use late_policy_params
    @aramasw
    aramasw committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ed9149b View commit details
    Browse the repository at this point in the history

  3. @kkotak @aramasw Fix build errors

    @aramasw
    aramasw committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    7090c8c View commit details
    Browse the repository at this point in the history

  4. @kkotak @aramasw Fix build errors

    @aramasw
    aramasw committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    2b20f7d View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2 from NitishKumar2404/beta 

    Refactor duplicate_name_check  and validate_input method
    @kalgeekotak99
    kalgeekotak99 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    9e745cb View commit details
    Browse the repository at this point in the history

  6. @kkotak @aramasw : Fixed the error message displayed

    @aramasw
    aramasw committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    f8c313e View commit details
    Browse the repository at this point in the history

  7. @kkotak @aramasw Fix build errors

    @aramasw
    aramasw committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    14baad5 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #3 from NitishKumar2404/beta 

    Fixed the Error message displayed
    @kalgeekotak99
    kalgeekotak99 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    0824566 View commit details
    Browse the repository at this point in the history

  9. @kkotak @aramasw Updated code to add valid_penalty checks

    @aramasw
    aramasw committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    3af63f2 View commit details
    Browse the repository at this point in the history

  10. @kkotak @aramasw : Fix Indentation Issue

    @aramasw
    aramasw committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    386363d View commit details
    Browse the repository at this point in the history

  11. Merge pull request #4 from NitishKumar2404/beta 

    Updated Code : Valid_penalty check
    @kalgeekotak99
    kalgeekotak99 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    3cc5959 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Merge branch 'expertiza:main' into beta

    @kalgeekotak99
    kalgeekotak99 committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    155acea View commit details
    Browse the repository at this point in the history

  2. @kkotak @aramasw Updated create and update methods, fixed error messages

    @aramasw
    aramasw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    67f26e8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'beta' of https://github.com/NitishKumar2404/Expertiza i… 

    …nto beta
    @aramasw
    aramasw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    4f2b8e8 View commit details
    Browse the repository at this point in the history

  4. @kkotak @aramasw Fix build issues

    @aramasw
    aramasw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    2b4ec05 View commit details
    Browse the repository at this point in the history

  5. @kkotak @aramasw Fix indentation issue, remove unused line,

    @aramasw
    aramasw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    d2c8942 View commit details
    Browse the repository at this point in the history

  6. @kkotak @aramasw Fixed variable assignment error

    @aramasw
    aramasw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    d603024 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into beta

    @kalgeekotak99
    kalgeekotak99 committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    d0b7517 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #5 from NitishKumar2404/beta 

    Refactor update and create methods
    @aramasw
    aramasw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c716317 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. @aramasw @kkotak Fix back link for edit assignment(late policy)

    @aramasw
    root authored and aramasw committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    d735ecf View commit details
    Browse the repository at this point in the history

  2. @aramasw @kkotak - Fix: Late policies Back link redirect to due dates… 

    … tab
    @aramasw
    aramasw committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    274d772 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Rename aid to assignment_id &Refactor assignment.find to find by id 

    Co-authored-by: aramasw
    Kalgee Anand Kotak committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f9ea0f2 View commit details
    Browse the repository at this point in the history

  2. @aramasw @kkotak: Add comments

    Kalgee Anand Kotak committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    53361bd View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. Merge branch 'program4' of https://github.com/NitishKumar2404/Expertiza… 

    … into main
    root committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    ae0228e View commit details
    Browse the repository at this point in the history