E2408. Refactor course.rb and course_team.rb models #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into course_team
Refactor course.rb
remove add_participant from course_team.rb
add add_participant and remove add_member
added 6 commits
March 24, 2024 09:31
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if options[:has_teamname] == 'true_first' || options[:has_teamname] == 'true_last' | ||
| name = row_hash[:teamname].to_s | ||
| team = where(['name =? && parent_id =?', name, id]).first | ||
| team = where(['name =? && parent_id =?', name, course_id]).first |
Check failure
Code scanning / CodeQL
SQL query built from user-controlled sources High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team Members:
Daksh Mehta, (unityID:dmehta4, GitHub:dakshmehta23)
Soham Patil, (unityID:sspatil6, GitHub:ThErOCk07)
Unnati Bukhariya, (unityID:ubukhar2, GitHub:unnzzz)
Mentor:
Ameya Vaichalkar, (unityID:agvaicha, GitHub:ameyagv)
wiki