Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2408. Refactor course.rb and course_team.rb models #2752

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

E2408. Refactor course.rb and course_team.rb models #2752

wants to merge 39 commits into from

Commits on Mar 15, 2024

  1. Initial commit for PR

    @dakshmehta23
    dakshmehta23 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d16b2de View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Copy method renamed

    @ThErOCk07
    ThErOCk07 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    943b22c View commit details
    Browse the repository at this point in the history

  2. id renamed to course_id

    @ThErOCk07
    ThErOCk07 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3b0233c View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Test Commit to README.md

    @unnzzz
    unnzzz committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    e4d3dad View commit details
    Browse the repository at this point in the history

  2. update schema.rb

    root committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    022e657 View commit details
    Browse the repository at this point in the history

  3. copy method renamed

    root committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8ca416a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/dakshmehta23/expertiza

    @ThErOCk07
    ThErOCk07 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8e3a7e7 View commit details
    Browse the repository at this point in the history

  5. Remove get_participant

    @dakshmehta23
    dakshmehta23 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ce67830 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Changes made

    root committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    98deb95 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dakshmehta23/expertiza into… 

    … main
    root committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    cf26577 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'course_team' of https://github.com/dakshmehta23/expertiza… 

    … into course_team
    root committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    949a8a8 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Merge branch 'expertiza:main' into dmehta4

    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    b381fd5 View commit details
    Browse the repository at this point in the history

  2. Remove corresponding rspectest for get_participant

    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    0561d1a View commit details
    Browse the repository at this point in the history

  3. rename copy_participants to copy_assignment_participants

    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    b2ee34e View commit details
    Browse the repository at this point in the history

  4. Update test cases to use copy_assignment_participants

    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    ee93ef5 View commit details
    Browse the repository at this point in the history

  5. Add comments to course.rb

    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    5e490a0 View commit details
    Browse the repository at this point in the history

  6. refactor add_participant to use find_by instead of where.first

    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    e3d9c3b View commit details
    Browse the repository at this point in the history

  7. Modified

    root committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    ea96f9f View commit details
    Browse the repository at this point in the history

  8. Remove assignment_id method from course_team.rb

    root committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    1255f50 View commit details
    Browse the repository at this point in the history

  9. Improve error handling in course.rb add_participant

    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    810a851 View commit details
    Browse the repository at this point in the history

  10. refactor error handling for copy_assignment_participants in course.rb

    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    a8925df View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into dmehta4

    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    0bd63fe View commit details
    Browse the repository at this point in the history

  12. Merge pull request #1 from dakshmehta23/dmehta4 

    Refactor course.rb
    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    44419f7 View commit details
    Browse the repository at this point in the history

  13. remove add_participant from course_team.rb

    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    541a006 View commit details
    Browse the repository at this point in the history

  14. Merge pull request #2 from dakshmehta23/dmehta4 

    remove add_participant from course_team.rb
    @dakshmehta23
    dakshmehta23 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    1f35f23 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Call copy_to_assignment_team method in controller

    root committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    c503007 View commit details
    Browse the repository at this point in the history

  2. Course.find(id) changed to Course.find(course_id)

    root committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    0e67c20 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into course_team

    root committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    69bed75 View commit details
    Browse the repository at this point in the history

  4. add add_participant and remove add_member

    @dakshmehta23
    dakshmehta23 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    e4375e5 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #3 from dakshmehta23/dmehta4 

    add add_participant and remove add_member
    @dakshmehta23
    dakshmehta23 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    e494685 View commit details
    Browse the repository at this point in the history

  6. Add add_particpant method back to course_team

    root committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    68c133b View commit details
    Browse the repository at this point in the history

  7. Merge main branch to course_team branch

    root committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    3d96345 View commit details
    Browse the repository at this point in the history

  8. Removed add_member test in course_team_spec.rb

    root committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    d84dbb1 View commit details
    Browse the repository at this point in the history

  9. Revert "Removed add_member test in course_team_spec.rb" 

    add_member test back in course_team_spec.rb This reverts commit d84dbb1.
    root committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    7dbf751 View commit details
    Browse the repository at this point in the history

  10. Revert "Merge main branch to course_team branch" 

    This reverts commit 3d96345, reversing
changes made to 68c133b.
    root committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    18a216a View commit details
    Browse the repository at this point in the history

  11. Revert "Modified" 

    This reverts commit ea96f9f.
    root committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    872e1b9 View commit details
    Browse the repository at this point in the history

  12. Updated course_team.rb to have import and export methods

    @unnzzz
    unnzzz committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    74e630a View commit details
    Browse the repository at this point in the history

  13. Created team_csv_handler.rb to handle csv import export

    @unnzzz
    unnzzz committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    bd294d9 View commit details
    Browse the repository at this point in the history

  14. Restore accidentally deleted methods

    @dakshmehta23
    dakshmehta23 committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    c3a5cdb View commit details
    Browse the repository at this point in the history