New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2403. Mentor-meeting management [Mentor Meeting Management and Emails Notifications] #2789
Open
Bala-Logesh
wants to merge
39
commits into
expertiza:main
Choose a base branch
from
ExtremeMachine12:mentor-mentee-cherry-picked
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
E2403. Mentor-meeting management [Mentor Meeting Management and Emails Notifications] #2789
Bala-Logesh
wants to merge
39
commits into
expertiza:main
from
ExtremeMachine12:mentor-mentee-cherry-picked
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses the partial name correctly. Added an html view for the emails being sent to users when added to teams. Added functionality such that mentored teams users get emails when added to teams. Lastly, added functionality such that the mentor gets a separate email letting them know they are mentoring a team now (there was already working functionality letting users know when a mentor is added to their team).
…displayed correctly.
…entors to be emailed when added to groups. Implemented new way for mentors to be emailed. Added html files for mentor added to group emails. Added an if statement to check whether a user is a mentor or not so they get the right email. Yes I would not do I type check if I didn't have to. However, since mentors are not of a different class than users, I can't actually use polymorphism to fix this issue unless I add an entire new mentor class to the system, which would be far out of the scope of this project.
…l when nil assignment ids were sent to add teams, and another random error where "participants" are sent as a user to add_teams. Apparently this is used for some other feature on Expertiza, but I'm not sure what. As it's outside the scope of this project I just added a type check so that "participants" aren't sent the email other users are. Also added tests for the new mailing functions.
…s to mentored teams. Tested that the code still works as intended.
…ler.rb class instead. Also renamed the function. Changed the implementation on the add_member function to call the new function. Also removed my email that got pushed by accident.
…on. Added comments to the "can_add_member" variable in the mentored team decorator. Simplified some code in the add_member function.
… add_member new mailer code. Also added a comment explaining the problem with sending the mail to a user classified as a Participant.
…ck participant. Fixed an error in the add_member function test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed in Pull Request:
Previous PRs made to the repository
PR#2769
PR#2772
Mentions:
@efg