Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2403. Mentor-meeting management [Mentor Meeting Management and Emails Notifications] #2789

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

Bala-Logesh
Copy link

Changes Proposed in Pull Request:

  • Create a new view that shows the team listing in a more intuitive and easy way.
  • Add input fields for each team where mentors and instructors can enter new, view, edit dates when mentor meetings were conducted.
  • Instructors can edit all dates for mentor meetings regardless of the team.
  • Mentors can also edit dates but only for the team they are mentoring.
  • Add more than three dates for the mentor meetings easily by pressing the + icon at the end of the view.
  • The meeting dates should not be editable for teams having capacity less than 50%.
  • Show user information in the view.
  • Added a new feature such that users are automatically emailed when they are added to a team. Also, mentors are automatically emailed a different email when they are added to a team.
  • Added a new function to the mailer_helper class for mail specifically sent to user/mentors when added to a team.
  • Added view partials to handle the HTML format of the new emails being sent.
  • Slightly changed the generic_message function in the mailer class to handle more cases.
  • Also added test cases to check that users/mentors are emailed when added to teams now.

Previous PRs made to the repository

PR#2769
PR#2772

Mentions:
@efg

ExtremeMachine12 and others added 30 commits March 14, 2024 10:39
…ses the partial name correctly. Added an html view for the emails being sent to users when added to teams. Added functionality such that mentored teams users get emails when added to teams. Lastly, added functionality such that the mentor gets a separate email letting them know they are mentoring a team now (there was already working functionality letting users know when a mentor is added to their team).
…entors to be emailed when added to groups. Implemented new way for mentors to be emailed. Added html files for mentor added to group emails. Added an if statement to check whether a user is a mentor or not so they get the right email. Yes I would not do I type check if I didn't have to. However, since mentors are not of a different class than users, I can't actually use polymorphism to fix this issue unless I add an entire new mentor class to the system, which would be far out of the scope of this project.
…l when nil assignment ids were sent to add teams, and another random error where "participants" are sent as a user to add_teams. Apparently this is used for some other feature on Expertiza, but I'm not sure what. As it's outside the scope of this project I just added a type check so that "participants" aren't sent the email other users are. Also added tests for the new mailing functions.
…s to mentored teams. Tested that the code still works as intended.
…ler.rb class instead. Also renamed the function. Changed the implementation on the add_member function to call the new function. Also removed my email that got pushed by accident.
…on. Added comments to the "can_add_member" variable in the mentored team decorator. Simplified some code in the add_member function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants