-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2403. Mentor-meeting management [Mentor Meeting Management and Emails Notifications] #2789
base: main
Are you sure you want to change the base?
E2403. Mentor-meeting management [Mentor Meeting Management and Emails Notifications] #2789
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 657a4f2 - Browse repository at this point
Copy the full SHA 657a4f2View commit details
Commits on Apr 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 14dfd6c - Browse repository at this point
Copy the full SHA 14dfd6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f60c76 - Browse repository at this point
Copy the full SHA 8f60c76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ff04b4 - Browse repository at this point
Copy the full SHA 4ff04b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a36ce82 - Browse repository at this point
Copy the full SHA a36ce82View commit details -
Fixed error in the send_team_confirmation email function so that it u…
…ses the partial name correctly. Added an html view for the emails being sent to users when added to teams. Added functionality such that mentored teams users get emails when added to teams. Lastly, added functionality such that the mentor gets a separate email letting them know they are mentoring a team now (there was already working functionality letting users know when a mentor is added to their team).
Configuration menu - View commit details
-
Copy full SHA for c96b16d - Browse repository at this point
Copy the full SHA c96b16dView commit details -
Fixed emails so that they actually get the assignment and teams name …
…displayed correctly.
Configuration menu - View commit details
-
Copy full SHA for 6b1512e - Browse repository at this point
Copy the full SHA 6b1512eView commit details -
Removed my testing email. Removed the way I implemented earlier for m…
…entors to be emailed when added to groups. Implemented new way for mentors to be emailed. Added html files for mentor added to group emails. Added an if statement to check whether a user is a mentor or not so they get the right email. Yes I would not do I type check if I didn't have to. However, since mentors are not of a different class than users, I can't actually use polymorphism to fix this issue unless I add an entire new mentor class to the system, which would be far out of the scope of this project.
Configuration menu - View commit details
-
Copy full SHA for 4e8b989 - Browse repository at this point
Copy the full SHA 4e8b989View commit details -
Ran tests and fixed two errors. One that was causing the tests to fai…
…l when nil assignment ids were sent to add teams, and another random error where "participants" are sent as a user to add_teams. Apparently this is used for some other feature on Expertiza, but I'm not sure what. As it's outside the scope of this project I just added a type check so that "participants" aren't sent the email other users are. Also added tests for the new mailing functions.
Configuration menu - View commit details
-
Copy full SHA for 97feed0 - Browse repository at this point
Copy the full SHA 97feed0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e810700 - Browse repository at this point
Copy the full SHA e810700View commit details -
Configuration menu - View commit details
-
Copy full SHA for 436fa7a - Browse repository at this point
Copy the full SHA 436fa7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2e5726 - Browse repository at this point
Copy the full SHA c2e5726View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbdf53e - Browse repository at this point
Copy the full SHA fbdf53eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 415cd88 - Browse repository at this point
Copy the full SHA 415cd88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72dff19 - Browse repository at this point
Copy the full SHA 72dff19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 562244c - Browse repository at this point
Copy the full SHA 562244cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ebfeeb - Browse repository at this point
Copy the full SHA 5ebfeebView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf4c60a - Browse repository at this point
Copy the full SHA cf4c60aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a78422b - Browse repository at this point
Copy the full SHA a78422bView commit details
Commits on Apr 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b22150d - Browse repository at this point
Copy the full SHA b22150dView commit details
Commits on Apr 18, 2024
-
Implemented decorator pattern for mentored teams. Fixed all reference…
…s to mentored teams. Tested that the code still works as intended.
Configuration menu - View commit details
-
Copy full SHA for 35e6870 - Browse repository at this point
Copy the full SHA 35e6870View commit details -
Removed team confirm email from mailer helper and moved it to the mai…
…ler.rb class instead. Also renamed the function. Changed the implementation on the add_member function to call the new function. Also removed my email that got pushed by accident.
Configuration menu - View commit details
-
Copy full SHA for 053f9ae - Browse repository at this point
Copy the full SHA 053f9aeView commit details
Commits on Apr 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 870b046 - Browse repository at this point
Copy the full SHA 870b046View commit details -
Configuration menu - View commit details
-
Copy full SHA for b22c0d9 - Browse repository at this point
Copy the full SHA b22c0d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 928c4a4 - Browse repository at this point
Copy the full SHA 928c4a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70ed24d - Browse repository at this point
Copy the full SHA 70ed24dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9b714d - Browse repository at this point
Copy the full SHA e9b714dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e8c072 - Browse repository at this point
Copy the full SHA 9e8c072View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d79ef1 - Browse repository at this point
Copy the full SHA 3d79ef1View commit details
Commits on Apr 23, 2024
-
Fixed mailer errors. Fixed the dry violation in the add_member functi…
…on. Added comments to the "can_add_member" variable in the mentored team decorator. Simplified some code in the add_member function.
Configuration menu - View commit details
-
Copy full SHA for 95e701c - Browse repository at this point
Copy the full SHA 95e701cView commit details -
root committed
Apr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for 03e8c5f - Browse repository at this point
Copy the full SHA 03e8c5fView commit details -
root committed
Apr 23, 2024 Configuration menu - View commit details
-
Copy full SHA for f3561b0 - Browse repository at this point
Copy the full SHA f3561b0View commit details -
Revised the old mailer test into a new add_member mailer test for the…
… add_member new mailer code. Also added a comment explaining the problem with sending the mail to a user classified as a Participant.
Configuration menu - View commit details
-
Copy full SHA for 260be76 - Browse repository at this point
Copy the full SHA 260be76View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a458c33 - Browse repository at this point
Copy the full SHA a458c33View commit details -
Added comments for the project E2403
root committedApr 24, 2024 Configuration menu - View commit details
-
Copy full SHA for 21709f6 - Browse repository at this point
Copy the full SHA 21709f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9275e26 - Browse repository at this point
Copy the full SHA 9275e26View commit details -
Added extra comments in mailer. Refactored team.rb as not to type che…
…ck participant. Fixed an error in the add_member function test.
Configuration menu - View commit details
-
Copy full SHA for c6b5196 - Browse repository at this point
Copy the full SHA c6b5196View commit details -
Configuration menu - View commit details
-
Copy full SHA for c61a121 - Browse repository at this point
Copy the full SHA c61a121View commit details -
root committed
Apr 24, 2024 Configuration menu - View commit details
-
Copy full SHA for 17f7202 - Browse repository at this point
Copy the full SHA 17f7202View commit details