Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2403. Mentor-meeting management [Mentor Meeting Management and Emails Notifications] #2789

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    657a4f2 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    14dfd6c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f60c76 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4ff04b4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a36ce82 View commit details
    Browse the repository at this point in the history
  5. Fixed error in the send_team_confirmation email function so that it u…

    …ses the partial name correctly. Added an html view for the emails being sent to users when added to teams. Added functionality such that mentored teams users get emails when added to teams. Lastly, added functionality such that the mentor gets a separate email letting them know they are mentoring a team now (there was already working functionality letting users know when a mentor is added to their team).
    ExtremeMachine12 authored and Bala-Logesh committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c96b16d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6b1512e View commit details
    Browse the repository at this point in the history
  7. Removed my testing email. Removed the way I implemented earlier for m…

    …entors to be emailed when added to groups. Implemented new way for mentors to be emailed. Added html files for mentor added to group emails. Added an if statement to check whether a user is a mentor or not so they get the right email. Yes I would not do I type check if I didn't have to. However, since mentors are not of a different class than users, I can't actually use polymorphism to fix this issue unless I add an entire new mentor class to the system, which would be far out of the scope of this project.
    ExtremeMachine12 authored and Bala-Logesh committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4e8b989 View commit details
    Browse the repository at this point in the history
  8. Ran tests and fixed two errors. One that was causing the tests to fai…

    …l when nil assignment ids were sent to add teams, and another random error where "participants" are sent as a user to add_teams. Apparently this is used for some other feature on Expertiza, but I'm not sure what. As it's outside the scope of this project I just added a type check so that "participants" aren't sent the email other users are. Also added tests for the new mailing functions.
    ExtremeMachine12 authored and Bala-Logesh committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    97feed0 View commit details
    Browse the repository at this point in the history
  9. Controller changes added

    root authored and Bala-Logesh committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e810700 View commit details
    Browse the repository at this point in the history
  10. Added view

    root authored and Bala-Logesh committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    436fa7a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c2e5726 View commit details
    Browse the repository at this point in the history
  12. Working on prefetching data

    root authored and Bala-Logesh committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    fbdf53e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    415cd88 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    72dff19 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    562244c View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    5ebfeeb View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    cf4c60a View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a78422b View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Updated the schema.rb file

    ExtremeMachine12 authored and Bala-Logesh committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    b22150d View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Implemented decorator pattern for mentored teams. Fixed all reference…

    …s to mentored teams. Tested that the code still works as intended.
    ExtremeMachine12 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    35e6870 View commit details
    Browse the repository at this point in the history
  2. Removed team confirm email from mailer helper and moved it to the mai…

    …ler.rb class instead. Also renamed the function. Changed the implementation on the add_member function to call the new function. Also removed my email that got pushed by accident.
    ExtremeMachine12 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    053f9ae View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Configuration menu
    Copy the full SHA
    870b046 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b22c0d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    928c4a4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    70ed24d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e9b714d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9e8c072 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3d79ef1 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Fixed mailer errors. Fixed the dry violation in the add_member functi…

    …on. Added comments to the "can_add_member" variable in the mentored team decorator. Simplified some code in the add_member function.
    ExtremeMachine12 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    95e701c View commit details
    Browse the repository at this point in the history
  2. Tests added

    root committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    03e8c5f View commit details
    Browse the repository at this point in the history
  3. Removed commit

    root committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f3561b0 View commit details
    Browse the repository at this point in the history
  4. Revised the old mailer test into a new add_member mailer test for the…

    … add_member new mailer code. Also added a comment explaining the problem with sending the mail to a user classified as a Participant.
    ExtremeMachine12 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    260be76 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    a458c33 View commit details
    Browse the repository at this point in the history
  2. Added comments for the project E2403

    root committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    21709f6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9275e26 View commit details
    Browse the repository at this point in the history
  4. Added extra comments in mailer. Refactored team.rb as not to type che…

    …ck participant. Fixed an error in the add_member function test.
    ExtremeMachine12 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c6b5196 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c61a121 View commit details
    Browse the repository at this point in the history
  6. Added more comments

    root committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    17f7202 View commit details
    Browse the repository at this point in the history