E1553 Refactoring versions_controller.rb #590

WintersLt · 2015-10-30T20:43:51Z

Fixes done:

Improved the clarity of code by improving the variable and parameter names.
Took the long character strings and give appropriate names
Pagination is handled by a separate helper module, which can be used by multiple controllers
action_allowed is implemented for access_control, which was missing before and hence everyone was able to access all methods
search.html.erb has been modified so that all versions for all users and tables are not displayed when a user views the index page
Added missing CRUD methods to VersionsController
Added RSPEC testcases for testing changes done in VersionsController

…T methods

…c of search and Index

WintersLt and others added 16 commits October 24, 2015 21:12

implementing action_allowed in versions controller and adding all RES…

fb6b94d

…T methods

modified variable names; added new private methods; modified the logi…

6123417

…c of search and Index

modified the search filter content for versions of a non admin user

3ab11fe

added database.yml.example file

fe4a063

functional tests for versions_controller.rb

34c8ab5

checked in versions.yml

0d7c301

checking in users.yml

b221f69

version controller rspec tests initial set

12c7879

Merge branch 'master' of https://github.com/WintersLt/expertiza

4835b18

removing commented code in version_spec

eb9b485

tests added for VersionsController

ce2fa56

Merge branch 'master' of https://github.com/WintersLt/expertiza

3e8a57c

adding test for destroy

ba8725a

deleting minitest written before rspec

b9ceb6e

restoring travis to previous versions

c629cfa

Merge remote-tracking branch 'upstream/master'

31d1d5d

yangsong8 closed this Dec 29, 2015

Winbobob added this to the CSC517 2015 Fall OSS Projects milestone Oct 3, 2016

Provide feedback