E1561. Refactoring due_date.rb and deadline_helper.rb #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… response_controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1: Remove DueDate.assign_topic_deadline and use DeadlineHelper.create_topic_deadline.
2: Create a new method for sorting deadlines in due_date.rb and invoke it from where it uses.
3: Rename setFlag() to adhere to Rails naming conventions.
4: Use the class variables in default_permission method and use conditionally check deadline type using if...else statements.
5: Refactor DeadlineHelper.set_start_due_date method to smaller methods.