-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing for addition of headless (token based) serving #41
Conversation
modified: expfactory/views/headless.py
modified: expfactory/templates/build/docker/builder-ci/build.sh
modified: expfactory/templates/build/docker/builder-ci/setup_build.sh
modified: cli/build.py
modified: expfactory/templates/build/docker/Dockerfile.dev modified: expfactory/templates/build/docker/Dockerfile.template
hey @earcanal ! I've added some very basic tests, specifically:
but circleCI is very limited in being able to execute commands to a container. I think for now we probably can do our best effort in these (somewhat manual) tests, and if you have tested to your satisfaction we can approve and merge and update with a new release. For things like the builder and the robots that I'm working on, my thinking is that those will be moved to their own respective repos so testing is a bit simpler. I don't want to let this PR turn into a larger monster than it already is. Let me know your thoughts! |
Nice! :) |
This PR will close #40 and #39. Specifically, additions are the following:
--headless
has been added as an option for start, meaning that the portal is closed off and tokens must be entered to participate. The experiments order is either preset with--experiments
and--no-randomize
, randomized (default) or filtered to a limited subset (--experiments
without--no-randomize
),expfactory logs
can be used inside the container to print out application logs. With--tail
they are left open for viewing updates.To properly review, we need help! @earcanal, you can use the full functionality of this PR by creating a Dockerfile with the development container.
and then build your container from that like before, and please be sure to test both filesystem and relational (sqlite) database types, along with the commands that are outlined in the new docs --> https://github.com/expfactory/expfactory/blob/headless/docs/pages/2-usage.md I've literally been working on this for 9.5 hours straight, so I'm going to take a break while you test. Let's check off the following:
When things look good I need to:
Thanks! I need to go for a run now... in the pitch black... lol