Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mypy in CI #30

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Enable mypy in CI #30

merged 2 commits into from
Mar 9, 2023

Conversation

shadeMe
Copy link
Collaborator

@shadeMe shadeMe commented Mar 9, 2023

Types of change

Chore

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@shadeMe shadeMe marked this pull request as draft March 9, 2023 10:27
@shadeMe shadeMe marked this pull request as ready for review March 9, 2023 11:53
svlandeg
svlandeg approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the CI is happy, I'm happy.

@svlandeg svlandeg merged commit 9bf2937 into explosion:main Mar 9, 2023
@shadeMe shadeMe deleted the chore/enable-mypy-ci branch March 9, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadeMe @svlandeg