Update sentencepiece to 0.1.98 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this targets |
shadeMe
approved these changes
May 24, 2023
| shell: bash | ||
|
|
||
| - name: Install test dependencies | ||
| run: pip install -r requirements.txt | ||
| run: python -m pip install -r requirements.txt | ||
|
|
||
| - name: Run pytest | ||
| run: python -m pytest --pyargs cutlery |
There was a problem hiding this comment.
I wonder if it'd make sense for us to also run the SentencePiece library's unit tests.
It'll probably be a hassle to build the library and the bindings, though.
There was a problem hiding this comment.
Yeah, I think building the module will be buggy/error prone, so probably not worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update sentencepiece to 0.1.98
Warning: do not merge or review:
Types of change
Enhancement
Checklist