id_to_piece and piece_to_id return None in case of invalid inputs
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
approved these changes
Jul 4, 2023
| def test_id_to_piece_and_piece_to_id(toy_processor): | ||
| assert toy_processor.piece_to_id("woord") == 4083 | ||
| assert toy_processor.piece_to_id("Ġwebsite") == 258 | ||
| assert toy_processor.piece_to_id("kglw") is None |
| @@ -148,12 +148,10 @@ def test_id_to_piece_and_piece_to_id(toy_model): | |||
| assert toy_model.piece_to_id("<s>") == toy_model.bos_id() | |||
| assert toy_model.piece_to_id("</s>") == toy_model.eos_id() | |||
| assert toy_model.piece_to_id("<unk>") == toy_model.unk_id() | |||
| assert toy_model.piece_to_id("qotsa") == toy_model.unk_id() | |||
| assert toy_model.piece_to_id("qotsa") is None | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normalize
id_to_pieceandpiece_to_idmethods (and their equivalents) across all processors to returnNoneinstead of throwing when an invalid piece or piece identifier is encountered.Types of change
Refactor
Checklist