Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for copy/deepcopy + SentencePieceProcessor deserialization bugfix #44

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Add support for copy/deepcopy + SentencePieceProcessor deserialization bugfix #44

merged 3 commits into from
Jul 6, 2023

Conversation

shadeMe
Copy link
Collaborator

@shadeMe shadeMe commented Jul 4, 2023

Description

deepcopy support is required for the replace_listeners functionality in spacy-curated-transformers.

Types of change

Enhancement/bugfix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@shadeMe shadeMe added bug Something isn't working enhancement New feature or request labels Jul 4, 2023
@shadeMe shadeMe mentioned this pull request Jul 4, 2023
Merged
3 tasks
danieldk
danieldk reviewed Jul 6, 2023
View reviewed changes
curated_tokenizers/_bbpe.pyx Outdated Show resolved Hide resolved
curated_tokenizers/_bbpe.pyx Outdated Show resolved Hide resolved
curated_tokenizers/_spp.pyx Show resolved Hide resolved
curated_tokenizers/_wordpiece.pyx Outdated Show resolved Hide resolved
curated_tokenizers/_wordpiece.pyx Outdated Show resolved Hide resolved
curated_tokenizers/_wordpiece.pyx Outdated Show resolved Hide resolved
@danieldk danieldk merged commit 5441dd8 into explosion:main Jul 6, 2023
6 checks passed
@shadeMe shadeMe deleted the feat/deep-copy branch July 6, 2023 14:45
shadeMe added a commit to shadeMe/curated-tokenizers that referenced this pull request Jul 6, 2023
@shadeMe
Add support for copy/deepcopy + SentencePieceProcessor deserial…
a771798 
…ization bugfix (explosion#44)

* Add support for `copy`/`deepcopy`

* `SentencePieceProcessor`: Handle zero-length protobufs during deserialization

* Remove code violating `deepcopy` semantics
Add comments
@shadeMe shadeMe mentioned this pull request Jul 6, 2023
Merged
3 tasks
shadeMe added a commit that referenced this pull request Jul 6, 2023
@shadeMe
Add support for copy/deepcopy + SentencePieceProcessor deserial…
7d2ee04 
…ization bugfix (#44) (#46)

* Add support for `copy`/`deepcopy`

* `SentencePieceProcessor`: Handle zero-length protobufs during deserialization

* Remove code violating `deepcopy` semantics
Add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadeMe @danieldk