Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{ByteBPE,SentencePiece}Processor: support file objects #51

Merged
merged 2 commits into from
Sep 14, 2023
Merged

{ByteBPE,SentencePiece}Processor: support file objects #51

merged 2 commits into from
Sep 14, 2023

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 7, 2023

Description

For fsspec support, we need to load tokenizers from file objects rather than paths. Support loading from either.

Types of change

Enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@danieldk danieldk added the enhancement New feature or request label Sep 7, 2023
@shadeMe shadeMe merged commit 40c35dd into explosion:main Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @shadeMe