Make all the piece processors picklable #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The piece processors are not pure Python classes, so could not be pickled. Implement `__reduce__` on all the processors to make them pickable. This is one step in making spaCy multiprocessing work. See: explosion/spaCy#13233
svlandeg
reviewed
Jan 17, 2024
|
Note to self: needs to be backported to spaCy 3.x branch. |
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
danieldk
added a commit
to danieldk/curated-tokenizers
that referenced
this pull request
Jan 17, 2024
* Make all the piece processors picklable The piece processors are not pure Python classes, so could not be pickled. Implement `__reduce__` on all the processors to make them pickable. This is one step in making spaCy multiprocessing work. See: explosion/spaCy#13233 * Type signature fix. Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com> * Pickling tests: check class --------- Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
3 tasks
danieldk
added a commit
that referenced
this pull request
Jan 17, 2024
* Make all the piece processors picklable The piece processors are not pure Python classes, so could not be pickled. Implement `__reduce__` on all the processors to make them pickable. This is one step in making spaCy multiprocessing work. See: explosion/spaCy#13233 * Type signature fix. * Pickling tests: check class --------- Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
danieldk
added a commit
to danieldk/curated-tokenizers
that referenced
this pull request
Apr 11, 2024
* Make all the piece processors picklable The piece processors are not pure Python classes, so could not be pickled. Implement `__reduce__` on all the processors to make them pickable. This is one step in making spaCy multiprocessing work. See: explosion/spaCy#13233 * Type signature fix. * Pickling tests: check class --------- Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The piece processors are not pure Python classes, so could not be pickled. Implement
__reduce__on all the processors to make them pickable.This is one step in making spaCy multiprocessing work.
See: explosion/spaCy#13233
Types of change
Feature
Checklist