Apply suggestions from code review

Co-authored-by: Renat Shigapov <57352291+shigapov@users.noreply.github.com>
explosion · Sep 23, 2021 · 57b5fc1 · 57b5fc1
1 parent 00836c2
commit 57b5fc1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/spacy/displacy/render.py b/spacy/displacy/render.py
@@ -316,6 +316,10 @@ def render_ents(
             end = span["end"]
             kb_id = span.get("kb_id", "")
             kb_url = span.get("kb_url", "")
+            if kb_id:
+                kb_link = """<a style="text-decoration: none; color: black; font-weight: bold" href="{}">{}</a>""".format(kb_url, kb_id)
+            else:
+                kb_link = ""
             additional_params = span.get("params", {})
             entity = escape_html(text[start:end])
             fragments = text[offset:start].split("\n")
@@ -325,7 +329,7 @@ def render_ents(
                     markup += "</br>"
             if self.ents is None or label.upper() in self.ents:
                 color = self.colors.get(label.upper(), self.default_color)
-                ent_settings = {"label": label, "text": entity, "bg": color, "kb_id": kb_id, "kb_url": kb_url}
+                ent_settings = {"label": label, "text": entity, "bg": color, "kb_link": kb_link}
                 ent_settings.update(additional_params)
                 markup += self.ent_template.format(**ent_settings)
             else:

diff --git a/spacy/displacy/templates.py b/spacy/displacy/templates.py
@@ -52,7 +52,7 @@
 <mark class="entity" style="background: {bg}; padding: 0.45em 0.6em; margin: 0 0.25em; line-height: 1; border-radius: 0.35em;">
     {text}
     <span style="font-size: 0.8em; font-weight: bold; line-height: 1; border-radius: 0.35em; vertical-align: middle; margin-left: 0.5rem">{label}
-    <a style="text-decoration: none; color: black; font-weight: bold" href="{kb_url}">{kb_id}</a>
+    {kb_link}
     </span>
 </mark>
 """