Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spacy.gold and spacy.morphology assumes that the 'SP' POS tags exists #683

Closed
Tpt opened this issue Dec 13, 2016 · 3 comments
Closed

spacy.gold and spacy.morphology assumes that the 'SP' POS tags exists #683

Tpt opened this issue Dec 13, 2016 · 3 comments
Labels
bug Bugs and behaviour differing from documentation

Comments

@Tpt
Copy link
Contributor

Tpt commented Dec 13, 2016

Spacy.gold and spacy.morphology both assumes that the 'SP' fine grain POS tag exists. It should be probably documented somewhere that the custom tag lists should include this POS tag.

An other possibility is to make Vocab and Tagger constructors automatically register it.

Your Environment

  • spaCy Version Used: 1.3
@honnibal honnibal added the bug Bugs and behaviour differing from documentation label Dec 18, 2016
@honnibal
Copy link
Member

Agreed, thanks!

@honnibal honnibal added this to the Reorganise language data milestone Dec 18, 2016
honnibal added a commit that referenced this issue Dec 18, 2016
@honnibal
Fix Issue #683: Add 'SP' to tag_map, if it's not there already, withi…
40e7158 
…n the Morphology class.
@honnibal
Copy link
Member

Fixed in the Morphology class, which I think should fix this elsewhere too.

honnibal pushed a commit that referenced this issue Jan 9, 2017
@syllog1sm
Revert "Fix Issue #683: Add 'SP' to tag_map, if it's not there alread…
95a5200 
…y, within the Morphology class."

This reverts commit 40e7158.
@honnibal honnibal mentioned this issue Jan 9, 2017
Closed
@honnibal honnibal reopened this Jan 9, 2017
@ines ines removed this from the Reorganise language data milestone Feb 18, 2017
@raphael0202 raphael0202 mentioned this issue May 12, 2017
Closed
@honnibal honnibal mentioned this issue Oct 20, 2017
Merged
8 tasks
@lock
Copy link

lock bot commented May 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tpt @honnibal @ines