Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NER check in CoNLL-U converter #10302

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Fix NER check in CoNLL-U converter #10302

merged 3 commits into from
Feb 21, 2022

Conversation

adrianeboyd
Copy link
Contributor

Description

Leave ents unset if no NER annotation is found in the MISC column.

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Fix NER check in CoNLL-U converter
b11073f 
Leave ents unset if no NER annotation is found in the MISC column.
@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface labels Feb 16, 2022
@adrianeboyd @svlandeg
Update spacy/training/converters/conllu_to_docs.py
afb22de 
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
@svlandeg svlandeg merged commit f32ee2e into explosion:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg left review comments

Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrianeboyd @svlandeg