Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vectors.n_keys for floret vectors #10394

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Fix Vectors.n_keys for floret vectors #10394

merged 1 commit into from
Mar 1, 2022

Conversation

adrianeboyd
Copy link
Contributor

Description

Fix Vectors.n_keys for floret vectors to match docstring description and avoid W007 warnings in similarity methods.

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Fix Vectors.n_keys for floret vectors
6931104 
Fix `Vectors.n_keys` for floret vectors to match docstring description
and avoid W007 warnings in similarity methods.
@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / vectors Feature: Word vectors and similarity feat / ux Feature: User experience, error messages etc. labels Feb 28, 2022
@svlandeg svlandeg merged commit 8e93fa8 into explosion:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / ux Feature: User experience, error messages etc. feat / vectors Feature: Word vectors and similarity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrianeboyd @svlandeg