Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook up meta in load_model_from_config #10400

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Mar 1, 2022

Description

Even though it was in the docstring, load_model_from_config wasn't taking in a meta argument, which meant that load_model_from_path wasn't using the input arg meta either.

Types of change

bug fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added bug Bugs and behaviour differing from documentation feat / config Feature: Training config labels Mar 1, 2022
@svlandeg svlandeg requested a review from ines March 1, 2022 17:54
@svlandeg svlandeg merged commit d89dac4 into explosion:master Mar 4, 2022
@svlandeg svlandeg deleted the fix/meta branch March 4, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and behaviour differing from documentation feat / config Feature: Training config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants