Fix StringStore.__getitem__ return type depending on parameter types #10741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small fix using `@overload` so that `StringStore.__getitem__` returns an `int` when given a `str` or `bytes` and a `str` when given an `int`.
|
This change makes sense, but it looks like mypy doesn't support it, at least not in the version we're currently using (until |
|
Sorry, I haven't tested it in mypy (only in pyright), and I didn't think that types were part of the tests (I just submitted the PR as a small patch via Github's online editor). I did check and it seems like @overload is used in other parts of Spacy though - will get a proper dev environment locally now and see what's up :-) |
adrianeboyd
reviewed
May 2, 2022
|
Sorry, had some trouble compiling locally - thanks for fixing it yourself! |
danieldk
pushed a commit
that referenced
this pull request
Jun 7, 2022
…10741) * Fix StringStore.__getitem__ return type depending on parameter types Small fix using `@overload` so that `StringStore.__getitem__` returns an `int` when given a `str` or `bytes` and a `str` when given an `int`. * Update spacy/strings.pyi Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix using
@overloadso thatStringStore.__getitem__returns anintwhen given astrorbytesand astrwhen given anint.Types of change
Small typing improvement
Checklist