Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove English exceptions with mismatched features #10873

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Remove English exceptions with mismatched features #10873

merged 1 commit into from
Jun 3, 2022

Conversation

adrianeboyd
Copy link
Contributor

Description

Remove English contraction exceptions with mismatched features that lead to exceptions like "theses" and "thisre".

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Remove English exceptions with mismatched features
15ecfa6 
Remove English contraction exceptions with mismatched features that lead
to exceptions like "theses" and "thisre".
@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation lang / en English language data and models v3.4 Related to v3.4 labels May 30, 2022
@adrianeboyd adrianeboyd linked an issue May 30, 2022 that may be closed by this pull request
Tokenization issue: theses #10699
Closed
@adrianeboyd
Copy link
Contributor Author

@explosion-bot please test_slow

@explosion-bot
Copy link
Collaborator

explosion-bot commented May 30, 2022 •
edited

🪁 Successfully triggered build on Buildkite

URL: https://buildkite.com/explosion-ai/spacy-slow-tests/builds/97

svlandeg
svlandeg approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix definitely makes sense :-)

@adrianeboyd adrianeboyd merged commit 727ce6d into explosion:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation lang / en English language data and models v3.4 Related to v3.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tokenization issue: theses
3 participants
@adrianeboyd @explosion-bot @svlandeg