vectors: avoid expensive comparisons between numpy ints and Python ints #10992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeMe
approved these changes
Jun 20, 2022
svlandeg
added
enhancement
|
@danieldk : could you have a look into the failing test? |
adrianeboyd
reviewed
Jun 22, 2022
polm
pushed a commit
that referenced
this pull request
Jul 11, 2022
…ts (#10992) * vectors: avoid expensive comparisons between numpy ints and Python ints * vectors: avoid failure on lists of ints * Convert another numpy int to Python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid expensive comparisons between numpy ints and Python ints when mapping hashes to rows in the embedding table. When doing some repeated benchmarks, this seems to improve performance by 800-900WPS on an 5950X.
Types of change
Performance improvement.
Checklist