displaCy: Fix horizontal spacing for multiple span labels #10994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
polm
added
bug
ljvmiranda921
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Thank you so much @pmbaumgartner ! I'd also ask @ines 's review to be sure! (can't seem to add reviewers)
pmbaumgartner
force-pushed
the
displacy-spans-fix
branch
from
7a27767
to
6ab0fe4
Compare
ines
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates displaCy's template and logic for calculating the vertical spacing between lines when there are multiple labels covering a single span.
Before (w/ prodigy comparison):
After: (Ignore specific span differences + lack of coloring)
Types of change
bug fix / enhancement
Checklist