Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust mkdir for pretrain command #11210

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Adjust mkdir for pretrain command #11210

merged 1 commit into from
Jul 26, 2022

Conversation

thomashacker
Copy link
Contributor

Description

This PR adds the parents=True argument to the mkdir command when initializing the directories. It's the same argument configuration as in the train command.

Types of change

Enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@thomashacker thomashacker added enhancement Feature requests and improvements feat / tok2vec Feature: Token-to-vector layer and pretraining labels Jul 26, 2022
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Definitely makes sense and it's more consistent :-)

@svlandeg svlandeg merged commit 360a702 into explosion:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / tok2vec Feature: Token-to-vector layer and pretraining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants