Allow string argument for disable/enable/exclude #11406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When loading an
nlp
pipeline, we assumed and documented thatdisable
,enable
andexclude
should be lists, but this wasn't enforced or checked, resulting in silent odd behavior when giving these arguments a single string:exclude="tok2vec"
did in fact work, by accident, because"tok2vec" in "tok2vec"
equalsTrue
because of substring comparisons.In this PR, we broaden the typing of the loading functions to include
str
as an option, and turn the string into alist
before anything else. This makes the functionality consistent with the current implementation ofnlp.select_pipes
, which also caters for both a single string and a list. Note that the implementation of_resolve_component_status
was allowing fordisable
to bestr
but the typing didn't reflect that, so I updated that as well.As part of the docs update, I also added the 3.4 tags for the new
enable
argument from #10784Types of change
bug/consistency fix
Checklist