Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for any non-Doc returned value for components #11424

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Check for any non-Doc returned value for components #11424

merged 1 commit into from
Sep 1, 2022

Conversation

adrianeboyd
Copy link
Contributor

Description

Check for any non-Doc returned value for components.

Types of change

?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added the feat / pipeline Feature: Processing pipeline and components label Sep 1, 2022
@adrianeboyd adrianeboyd linked an issue Sep 1, 2022 that may be closed by this pull request
[E871] error when n_process > 1 with custom component #11413
Closed
@adrianeboyd adrianeboyd added the feat / ux Feature: User experience, error messages etc. label Sep 1, 2022
svlandeg
svlandeg approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@svlandeg svlandeg merged commit 78f5503 into explosion:master Sep 1, 2022
polm pushed a commit to polm/spaCy that referenced this pull request Sep 6, 2022
@adrianeboyd @polm
Check for any non-Doc returned value for components (explosion#11424)
914d76c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
feat / pipeline Feature: Processing pipeline and components feat / ux Feature: User experience, error messages etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[E871] error when n_process > 1 with custom component
2 participants
@adrianeboyd @svlandeg