Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports and other fixes for v3.3.3 #12671

Merged
merged 6 commits into from
May 25, 2023

Conversation

adrianeboyd
Copy link
Contributor

Description

Backports for v3.3.3.

Types of change

Bug fixes.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added the v3.3 Related to v3.3 label May 24, 2023
@adrianeboyd adrianeboyd marked this pull request as draft May 24, 2023 18:55
@adrianeboyd adrianeboyd force-pushed the backport/v3.3.3 branch 2 times, most recently from d750b01 to c4b3d83 Compare May 24, 2023 19:07
adrianeboyd and others added 6 commits May 24, 2023 21:15
* avoid nesting then flattening

* mypy fix

* Apply suggestions from code review

* Add type for indices

* Run full matrix for mypy

* Add back modified type: ignore

* Revert "Run full matrix for mypy"

This reverts commit e218873.

---------

Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
The current URLs will become invalid in pip 25.0. According to the pip
docs, the egg= URLs are currently only needed for editable VCS installs.
@adrianeboyd adrianeboyd marked this pull request as ready for review May 25, 2023 06:26
@adrianeboyd adrianeboyd merged commit fa9d24e into explosion:v3.3.x May 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.3 Related to v3.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants