Update numpy build constraints for numpy 1.25 #12839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in numpy 1.25 (see https://github.com/numpy/numpy/releases/tag/v1.25.0), the numpy C API is backwards-compatible by default. For python 3.9+, we should be able to drop the specific numpy build requirements and use `numpy>=1.25`, which is currently backwards-compatible to `numpy>=1.19`. In the future, the python <3.9 requirements could be dropped and the lower numpy pin could correspond to the oldest supported version for the current lower python pin.
|
The CI does not currently really test this, since numpy isn't downgraded after building. From what I understand the lower numpy build constraint will need to be |
This reverts commit 4306f51.
rmitsch
reviewed
Jul 21, 2023
rmitsch
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting in numpy 1.25 (see
https://github.com/numpy/numpy/releases/tag/v1.25.0, https://numpy.org/doc/1.25/dev/depending_on_numpy.html), the numpy C API is backwards-compatible by default.
For python 3.9+, we should be able to drop the specific numpy build requirements and use
numpy>=1.25, which is currently backwards-compatible tonumpy>=1.19.In the future when python 3.8 is dropped, the specific python <3.9 requirements could be dropped and the lower numpy pin could correspond to the oldest supported version for the current lower python pin.
Types of change
?
Checklist