Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indonesian language support #1288

Merged
merged 56 commits into from Aug 26, 2017

Conversation

Projects
None yet
4 participants
@geovedi
Copy link

geovedi commented Aug 25, 2017

Description

This is the preliminary work on adding Indonesian language support.

Types of changes

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality to spaCy)
  • Breaking change (fix or feature causing change to spaCy's existing functionality)
  • Documentation (addition to documentation of spaCy)

Checklist:

  • My change requires a change to spaCy's documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ines ines added the 🌙 nightly label Aug 26, 2017

@honnibal

This comment has been minimized.

Copy link
Member

honnibal commented Aug 26, 2017

Thanks! So good :). Sorry I kept you waiting on the data sample!

This is ready to merge right? The changes look good, and it's all within the new package, so I don't see a problem.

@honnibal honnibal merged commit 2e28982 into explosion:develop Aug 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@geovedi geovedi deleted the geovedi:indonesian branch Aug 26, 2017

@geovedi

This comment has been minimized.

Copy link
Author

geovedi commented Aug 26, 2017

thanks! some works still need to be done, but now i'm focusing on making training data publicly available.

@ines ines added the lang / id label Sep 26, 2017

@erwinyusrizal

This comment has been minimized.

Copy link

erwinyusrizal commented Mar 15, 2018

Hello guys, any update on indonesian language?

@geovedi

This comment has been minimized.

Copy link
Author

geovedi commented Mar 15, 2018

not yet, been doing something else for the last few months. but feel free to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.