Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn for unsupported key in dependency matcher #12928

Merged
merged 1 commit into from Aug 22, 2023

Conversation

svlandeg
Copy link
Member

Follow-up to #12926.

Description

The Dependency Matcher only supports 4 specific keys in the (sub)pattern dictionaries. While it may be reasonable to assume that e.g. 'OP' is supported, it's not, and currently this would be entirely ignored if you do try to specify it. Instead, this PR ensures a warning is printed:

UserWarning: [W126] These keys are unsupported: OP, FOO

Types of change

UX enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added feat / matcher Feature: Token, phrase and dependency matcher feat / ux Feature: User experience, error messages etc. enhancement Feature requests and improvements labels Aug 21, 2023
@svlandeg svlandeg merged commit 869cc4a into explosion:develop Aug 22, 2023
9 checks passed
@svlandeg svlandeg deleted the feature/raise_invalid branch August 22, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / matcher Feature: Token, phrase and dependency matcher feat / ux Feature: User experience, error messages etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants