Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom code support to CLI speed benchmark #13247

Merged
merged 3 commits into from Jan 26, 2024

Conversation

evornov
Copy link
Contributor

@evornov evornov commented Jan 18, 2024

Description

Adds --code option to the speed benchmark CLI command so that pipelines with custom components can be benchmarked.
I used [doc.from_docs([doc]) for doc in docs] to deep-copy the warmup docs to prevent errors with pipelines that modify sentence boundaries. Happy to change this to something else if there's a more idiomatic way to copy those docs!

Types of change

CLI enhancement + associated documentation update

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added feat / cli Feature: Command-line interface enhancement Feature requests and improvements labels Jan 19, 2024
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, we forgot this option when adding the benchmark speed subcommand.

spacy/cli/benchmark_speed.py Outdated Show resolved Hide resolved
@danieldk danieldk merged commit 00e938a into explosion:master Jan 26, 2024
13 checks passed
@danieldk
Copy link
Contributor

Awesome, thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements feat / cli Feature: Command-line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants