Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #13469

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Fix CI #13469

merged 2 commits into from
Apr 29, 2024

Conversation

svlandeg
Copy link
Member

Description

  • macos-latest is now ARM64, but we were forcefully setting x86. Always build for the native platform instead.
  • Update setup classifiers to include support for Python 3.12 (which was already present)

Types of change

CI fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the tests New, missing or incorrect tests label Apr 29, 2024
@svlandeg svlandeg marked this pull request as ready for review April 29, 2024 08:17
@svlandeg svlandeg merged commit 6d6c10a into explosion:master Apr 29, 2024
9 checks passed
@svlandeg svlandeg deleted the fix/ci branch April 29, 2024 08:18
This was referenced Apr 29, 2024
Draft
Merged
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 3, 2024
@jikanter
Fix CI (explosion#13469)
9628790 
* Remove hardcoded architecture setting

* update classifiers to include Python 3.12
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 21, 2024
@jikanter
Fix CI (explosion#13469)
3adfc02 
* Remove hardcoded architecture setting

* update classifiers to include Python 3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests New, missing or incorrect tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@svlandeg