Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conllu2json converter to output all sentences when n > 1 #4656

Merged
merged 1 commit into from Nov 15, 2019
Merged

Fix conllu2json converter to output all sentences when n > 1 #4656

merged 1 commit into from Nov 15, 2019

Conversation

adrianeboyd
Copy link
Contributor

Description

Make sure that the last batch of sentences is output when -n is greater than 1.

Types of change

Bugfix.

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Fix conllu2json converter to output all sentences
81c19dd 
Make sure that the last batch of sentences is output if n_sents > 1.
@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface labels Nov 15, 2019
@ines ines merged commit bdfb696 into explosion:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / cli Feature: Command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrianeboyd @ines