Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armenian language support #5246

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Armenian language support #5246

merged 2 commits into from
Apr 3, 2020

Conversation

YohannesDatasci
Copy link
Contributor

Description

Added Armenian language support. changes are the inclusion of stop words, tag_map obtained from UniversalDependencies-Armenian-TDP and lex_attrs of numeric values in Armenian language.
Tests include tokenizer and lex_attrs testing.

Types of change

enhancement

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the enhancement Feature requests and improvements label Apr 2, 2020
@honnibal honnibal merged commit beef184 into explosion:master Apr 3, 2020
"տասն­յոթ",
"տասն­ութ",
"տասն­ինը",
"քսան" "երեսուն",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. A comma is needed between these.


_num_words = [
"զրօ",
"մէկ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is "զրո", "մեկ" instead.

@svlandeg svlandeg added the lang / hy Armenian language data and models label Jun 19, 2020
@svlandeg
Copy link
Member

Hi @mahnerak, sorry to follow up so late, but I think we didn't see your comments as this PR was already merged when you made them. I did notice that your last comment is included in a new PR though - PR #5608. Feel free to make any additional changes in a new PR as well !

@svlandeg svlandeg mentioned this pull request Jun 19, 2020
3 tasks
@polm polm added the new language Adding support for new languages to spaCy. label Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements lang / hy Armenian language data and models new language Adding support for new languages to spaCy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants